more cleaning and adding some benchmark results. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Nuon
reviewed
Jun 18, 2024
benchmark/Benchmark.cs
Outdated
| BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args, DefaultConfig.Instance.AddJob(job).WithSummaryStyle(SummaryStyle.Default.WithMaxParameterColumnWidth(100))); | ||
| } | ||
| } | ||
| // static void Main(string[] args) => BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args, DefaultConfig.Instance |
There was a problem hiding this comment.
I think this commented out code might no longer be necessary?
the above line seems to be working fine.
Nick-Nuon
approved these changes
Jun 18, 2024
|
Good catch. Merging. |
|
@Nick-Nuon Tests are failing because the project is out of money. I have been trying to put more money in the system but I have failed so far. Don't worry about it. |
|
@Nick-Nuon I have merged and added a budget for the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as we have AVX-512 support, we shall be able to do the same for x64. I have added a section in the README which we should fill out.