Added BZip2 compression filter #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: src/bzip2 git-subtree-split: 75a94bea3918e612b879d6a11ca64b8689526147
t20100
commented
Jun 3, 2022
| @@ -0,0 +1,28 @@ | |||
| /* | |||
There was a problem hiding this comment.
This extra code is needed to make the filter a "plugin".
|
Let's keep this as a Draft PR for now, and wait for an effective need to add it to |
|
For easy-to-handle filters I do not mind to add them to the code repository. If PyTables uses it, I would add it. |
|
OK, up to you then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the BZip2 compression filter from
PyTablestohdf5plugin.It also updates slightly the contribution documentation.
I didn't use
git subtreefor PyTables, instead I copy-pasted the 3 relevant files while keeping the same folder structure. As we add filters, we're also adding a lot of useless files, so maybe time to change the strategy of embedding everything, what do you think of this?I'm also missing a hdf5 file with bzip2 compression that was produced by another tool.
Related to #110