Repository navigation
fix(resume-checker): include template instruction in grading prompt - #63
Open
AugustoCarmona wants to merge 1 commit into
Open
AugustoCarmona wants to merge 1 commit into
AugustoCarmona wants to merge 1 commit into
Conversation
|
@AugustoCarmona is attempting to deploy a commit to the conanbatt's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSysPrompt builds the grading prompt with
${isSilver ?? "- Do NOT mention ANYTHING regarding the template"}.isSilveris a boolean, and??only falls through onnullorundefined, so the instruction never reaches the prompt and the literaltrueorfalseis injected into it instead.I noticed it as a user: a resume built with the
silver-dev-cvTypst template was flagged for not using the template.The fix is a one-line change to a ternary, so the instruction is included when the PDF author is
silverand nothing is added otherwise.I can add a test under
tests/resume-checker/if you would like one.Need help on this PR? Tag
@codesmith-botwith what you need.