Skip to content

fix(ai): log roast-me stream failures and pass system prompts via system #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lautaropaske merged 1 commit into from
Oct 2, 2026
Merged

fix(ai): log roast-me stream failures and pass system prompts via system #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/app/roast-me/api/analyze/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,10 @@ export async function POST(req: NextRequest) {
strictJsonSchema: true,
},
},
messages: [
{
role: "system",
content: isUnhinged ? SYSTEM_PROMPT_UNHINGED : SYSTEM_PROMPT,
},
{ role: "user", content: [{ type: "image", image: snapshot }] },
],
system: isUnhinged ? SYSTEM_PROMPT_UNHINGED : SYSTEM_PROMPT,
messages: [{ role: "user", content: [{ type: "image", image: snapshot }] }],
onError: ({ error }) =>
console.error("[roast-me/analyze] stream failed", error),
});

return result.toTextStreamResponse();
Expand Down
4 changes: 3 additions & 1 deletion src/pages/api/grade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
} from "@/resume-checker/fetch-resume";
import {
exampleResponses,
getSysPrompt,
messages,
ResponseData,
ResponseSchema,
Expand Down Expand Up @@ -76,7 +77,8 @@ export default async function handler(
const completion = await generateObject({
model: "google/gemini-2.5-flash",
temperature: 0,
messages: messages(parsed, pdfBuffer),
system: getSysPrompt(parsed?.info?.Author),
messages: messages(pdfBuffer),
schema: ResponseSchema,
});

Expand Down
11 changes: 2 additions & 9 deletions src/resume-checker/prompts/grade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,7 @@ function createInput(data: Buffer): ModelMessage {
}

/* Moving the fs.readFileSync call deeper causes an error when reading files */
export function messages(
parsed: { text: string; info?: any },
pdfBuffer: Buffer,
): ModelMessage[] {
export function messages(pdfBuffer: Buffer): ModelMessage[] {
const trainMessages: ModelMessage[] = [
{
data: fs.readFileSync(path.join(process.cwd(), "public/s_resume.pdf")),
Expand All @@ -183,11 +180,7 @@ export function messages(
createAssistantResponse(response),
]);

return [
{ role: "system", content: getSysPrompt(parsed?.info?.Author) },
...trainMessages,
createInput(pdfBuffer),
];
return [...trainMessages, createInput(pdfBuffer)];
}

function hasGmail(flag: string) {
Expand Down
6 changes: 2 additions & 4 deletions src/takehome-checker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@ export async function analyzeTakeHome(

const { text } = await generateText({
model: openai("gpt-4o-mini"),
messages: [
{ role: "system", content: prompt },
{ role: "user", content },
],
system: prompt,
messages: [{ role: "user", content }],
maxOutputTokens: 10000,
temperature: 0,
});
Expand Down
Loading