Repository navigation
refactor: improve grade route error handling and coverage - #12
Closed
lautaropaske wants to merge 4 commits into
Closed
lautaropaske wants to merge 4 commits into
lautaropaske wants to merge 4 commits into
Conversation
Normalize plain-text grade failures so oversized uploads and upstream text responses surface as user-readable errors instead of JSON parse exceptions. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Add direct handler coverage for the grade route and lock the client-side fallback cases so JSON and plain-text error paths stay verifiable without new test dependencies. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Return structured JSON for app-generated grade route failures so invalid request, invalid PDF, and unexpected error paths stay machine-readable while preserving the existing upload flow. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lautaropaske
changed the title
lautaropaske
marked this pull request as ready for review
July 22, 2026 12:58
Wire up `bun run test` and a GitHub Actions workflow (lint, typecheck, test) so the new grade route tests actually run somewhere. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xq4oNTbLpPej9iZv14NkJJ
This was referenced Aug 25, 2026
Contributor
Author
|
Superseded by #32. The route changes here were overtaken by a8e92c1, which does the same 4xx normalization on The client-side half was still a real bug on |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/gradefailures to structured JSON while preserving the existing client fallback for upstream plain-text413responses/api/gradesuccess, invalid request, invalid PDF, and unexpected error paths plus regression coverage for the resume-checker error parserTesting
bunx vitest run src/pages/api/grade.test.tsbunx vitest run src/resume-checker/utils.test.tsbunx tsc --noEmitcurlforGET /api/grade?url=public/a_resume.pdf, malformed multipartPOST /api/grade, andPUT /api/gradeKnown issue
bun run buildstill fails because the repo currently has a React version mismatch (react@19.2.0vsreact-dom@19.2.3); this branch does not change those dependencies