SF-3578 Add Import Questions from Paratext notes #3570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmyers
added
the
will require testing
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3570 +/- ##
==========================================
- Coverage 82.83% 82.75% -0.08%
==========================================
Files 610 612 +2
Lines 37217 37462 +245
Branches 6101 6122 +21
==========================================
+ Hits 30828 31001 +173
- Misses 5462 5530 +68
- Partials 927 931 +4 ☔ View full report in Codecov by Sentry. |
josephmyers
force-pushed
the
feature/SF-3578
branch
from
438bf12 to
c50a90f
Compare
Collaborator
Author
|
One thing I intentionally haven't done here is to exclude resolved notes/questions, the reasons being that, if we do, there's no option for the user to bypass that and that, if they really don't want to see the item in the import list, they can just delete it in Paratext. |
Nateowami
changed the title
josephmyers
force-pushed
the
feature/SF-3578
branch
from
31298b4 to
5794303
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
josephmyers
force-pushed
the
feature/SF-3578
branch
4 times, most recently
from
b5d8d6e to
d8a97d9
Compare
The notes are fetched from the Paratext local copy, and the relevant pieces are parsed. The back end replaces the tag numbers with their user-displayed text (for readability). The front end makes this call when the user clicks the Paratext Import option in the import dialog. It first gathers the available tags and displays them as a dropdown. Once a value is chosen, it filters the notes down to the selection, and feeds them to the same display used for the Transcelerator questions. The brunt of this is done, but there are a number of edge cases to work through. And tests.
And fixed layout squashing on intermediate sizes And hooked up Learn More to Transcelerator help page (until this feature gets its own)
Before, follow-on steps in the dialog were "cancel" buttons, which would just close the dialog. This wasn't great UX. Now, all the major states of the dialog should allow the user to get back to the initial state. I had to split out the filter state into two states, since the Back for the Paratext notes (the new step) has to go to the Tag screen, not the initial.
Front end tests still remaining
… use Where Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… use Where Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Nateowami
force-pushed
the
feature/SF-3578
branch
from
d8a97d9 to
abbf519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notes are fetched from the Paratext local copy, and the relevant pieces are parsed. The back end replaces the tag numbers with their user-displayed text (for readability).
The front end makes this call when the user clicks the Paratext Import option in the import dialog. It first gathers the available tags and displays them as a dropdown. Once a value is chosen, it filters the notes down to the selection, and feeds them to the same display used for the Transcelerator questions.
This change is