Move commands to separate modules #1814
Conversation
cmurphy
force-pushed
the
gowork
branch
3 times, most recently
from
07db89f to
0352963
Compare
|
|
cmurphy
force-pushed
the
gowork
branch
2 times, most recently
from
8999a11 to
b5dc4dd
Compare
|
curious if bob's change affects this in any way too: #1820 |
we could just set up rules for each app if we don't want them all grouped together for some reason. |
| - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
| go-version: stable |
There was a problem hiding this comment.
i think you could use go.work here and achieve the same effect as before.
.github/workflows/verify.yml
Outdated
| outputs: | ||
| modules: ${{ steps.set-modules.outputs.modules }} | ||
| steps: | ||
| - uses: actions/checkout@v5 |
There was a problem hiding this comment.
| - uses: actions/checkout@v5 | |
| - uses: actions/checkout@v5 | |
| with: | |
| persist-credentials: false |
.github/workflows/verify.yml
Outdated
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-go@v6 |
There was a problem hiding this comment.
please pin the actions to a commit SHA
Make each helper command its own module to avoid maintaining every tool's dependencies in a single go.mod. Also remove update-deps.sh and update-codegen.sh which weren't used anywhere. Signed-off-by: Colleen Murphy <[email protected]>
| @@ -0,0 +1,181 @@ | |||
| module github.com/sigstore/scaffolding/hack | |||
|
|
|||
| go 1.25.0 | |||
There was a problem hiding this comment.
should/can we take all these go versions out and just depend on the one defined in go.work? It's not clear to me what best practice is.
There was a problem hiding this comment.
I don't think we can do that? I didn't come across a syntax for that while I was looking at examples. And this way the module doesn't have to know that it's a submodule, it can be totally independent.
3 participants
Make each helper command its own module to avoid maintaining every tool's dependencies in a single go.mod.
Also remove update-deps.sh and update-codegen.sh which weren't used anywhere.
Summary
Release Note
Documentation