-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kingst-la2016: Submit first version of open firmware for the fx2 mcu #1
base: master
Are you sure you want to change the base?
Conversation
@Planet911 I will give it a go, primarily on the SD SPI and the 1-Wire protocols analysers. |
@Planet911 Just a quick question, is this FW release expected to help/fix any of the Known issues ? |
No, afraid not. All the known issues / missing features are within PulseView. This firmware is, in essence, providing documentation of the usb protocol and thus helps developers understand what the libsigrok driver is doing. It also protects against changes in the oem firmware which could adversely affect sigrok compatibility. |
Thanks for in-lighting me! |
Just did a small update to the firmware file kingst-la-01a2.fw (which now has crc32 of 0x0857cb80) |
I have tested the new firmware. It works without any problem with PulseView and sigrok-cli. It would be great to have the firmware in the official release of sigrok. |
@harper23 Thanks for taking the time to test it 👍 |
I have tested the new firmware on PulseView as well and haven't observed any issues so far. |
No, the sigrok-firmware repository is not a good location for the source code. It contains binaries only by design. If you got OpenSource firmware (new implementations or extensions to existing setups) then consider the sigrok-firmware-fx2lafw repository. Am saying that without having looked at any other part of your submission. Because firmware extraction from the vendor software is required in any case to get the FPGA netlist blob. Have been using mainline sigrok in combination with vendor firmware from different v3.5.x versions (3.5.1 to 3.5.5 which all contained the same blobs). So no feedback from me on your MCU firmware here. |
Currently, for the Kingst logic analysers users need to extract the firmware (for the fx2 mcu) and bitstreams (for the fpga) from the oem software. This PR provides open firmware which is a drop-in replacement for the oem fx2 firmware. The firmware is relatively simple, just doing data moving operations - see the wiki for more detail
The sigrok-firmware repository seemed a logical location, although it does not currently contain any source code. The firmware binary file *.fw needs to be built and copied manually to the kingst-la2016 directory. From there it will be included in the distribution directory.
I have tested this with PulseView on the la2016 and la1016 but it would help get it pulled if others could also test. Simply replace the oem firmware file (kingst-la-01a2.fw) with the one in this PR (kingst-la2016/kingst-la-01a2.fw). Disconnect the analyser from usb, then reconnect and start PulseView to ensure the new firmware is being used. There should be no noticeable functional differences.
Edit: Link to the pre-built open firmware