PJDL and PJON improvements plus addition of stacked ModuleInterface decoder #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged from sigrokdecode master
Added new warning annotations for missing ACK and nonconformance. Added timings and tolerances from PJDL spec. Added support for extended leading pad. Added weak noise peak tolerance, detection and warning. Added check of total width of zero bit + 8 data bits. Added check of frame init width. Increased tolerance to differing timings between devices (within new tolerances from spec).
Added output 'pjon' to stacked decoders. Added reading of port number.
The ModuleInterface decoder is stacked on top of PJON. It shows the packet type, variable count and contents of the different packets used by the protocol, including variable contract exchange packets, variable value packets and time sync packets (broadcast and/or targeted).
|
These decoders are tested with PulseView 32 bit Windows nightbuild from 2020-11-01, and PJON 13.0 and ModuleInterface 4.0. |
|
Data dumps are present in sigrokproject/sigrok-dumps#32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual detailed comments on each of the 3 commits.
Summary:
PJDL decoder improvements to robustness and warnings.
PJON decoder reading port number and emitting 'pjon' output to stacked decoders.
Added stacked decoder for the ModuleInterface protocol that is built on top of PJON.