Skip to content

Clean up bulk_update semantics#101

Open
michaelsproul wants to merge 1 commit into
mainfrom
bulk_update
Open

Clean up bulk_update semantics#101
michaelsproul wants to merge 1 commit into
mainfrom
bulk_update

Conversation

@michaelsproul

Copy link
Copy Markdown
Member

In the course of implementing:

I found that bulk_update was a bit of a footgun. It would fail unnecessarily if there were any pending updates, and it would also silently accept invalid updates which would later fail to apply when apply_updates was called.

This PR fixes both of these issues, and adds unit tests and proptests for bulk_update.

@michaelsproul michaelsproul requested a review from macladson May 12, 2026 04:21
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.02%. Comparing base (8963bc5) to head (0f11e65).

Files with missing lines Patch % Lines
src/list.rs 75.00% 4 Missing ⚠️
src/vector.rs 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   70.15%   72.02%   +1.86%     
==========================================
  Files          22       22              
  Lines        1280     1301      +21     
==========================================
+ Hits          898      937      +39     
+ Misses        382      364      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants