Fix placeholder access arguments that do not map to objects#1008
Open
jacobembree wants to merge 1 commit intosignalpoint:7.x-1.xfrom
Open
Fix placeholder access arguments that do not map to objects#1008jacobembree wants to merge 1 commit intosignalpoint:7.x-1.xfrom
jacobembree wants to merge 1 commit intosignalpoint:7.x-1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a placeholder access argument maps to a loaded object the list of access arguments at position
indexgets replaced with the loaded object. However, when there's no entity and a specific path component is chosen by number in access_arguments, the number indicating the path component is ignored, only the the index of the number in the list of access arguments is used.This pull request fixes that by calling
arg()with the number specified rather than position of the number.