#5488 Drag and Drop Images #6053
Open
+89
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b26e5a01c3e831a16c31435f9aa60356ff58f45c)
(cherry picked from commit 913bb4ea2d42a6f6c1fec2792c18e5fd8a575e43)
(cherry picked from commit 91cc49b998acc42df26f6bb6e6a58eec6d97400f)
|
Looking at this PR taught me that dragging and dropping images is even possible in iOS! 🤩 Seems like a pretty nifty feature to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
This pull request introduces (
fixes #5488) a common feature in many chatting applications, but is not currently present in Signal. This feature allows the user to drag and drop images straight into any conversation thread. I tested this by dragging and dropping different image UTIs (pngs, jpegs, etc) along with images that are and arent sticker size (images below 512 pixels).Test dragging into text input bar
5488-1.mov
Test dragging into conversation view controller view
5488-2.mov