Skip to content

Add Linux arm64 to CI pipeline #7202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dennisameling
Copy link
Contributor

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A pnpm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Similar to signalapp/ringrtc#61, this PR adds the newly available GitHub Linux arm64 hosted runners to the CI pipeline. I've confirmed this to work.

I understand that this does not mean that Signal will start shipping Linux arm64 binaries, but this could be a first step to ensure things keep building reliably on Linux arm64.

@trevor-signal trevor-signal self-requested a review March 6, 2025 22:06
Copy link

stale bot commented Jun 11, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2025
@mkurz
Copy link

mkurz commented Jun 11, 2025

Please keep open.

@stale stale bot removed the stale label Jun 11, 2025
@WhyNotHugo
Copy link
Contributor

Needs rebase

Comment on lines +196 to +199
# Needed because electron-builder's bundled FPM doesn't support arm64
- name: Install FPM (for packaging)
if: ${{ matrix.os == 'ubuntu-22.04-arm64-4-cores' }}
run: sudo gem install fpm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting with electron-builder 26.0.18, this workaround will no longer be needed as Linux arm64 binaries have been added for fpm.

However, that version is currently in pre-release, so I guess folks will want to wait for a next official release prior to updating to that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants