test: SKA op2 gap tests + doc updates (411/411)#3
Merged
Conversation
Add 4 tests covering the op2 partial eval sub-cases that were missing:
(a) NOMM_I2 via SKNOCK — dynamic formula slot, cape=wildcard,
run_nomm1 takes the q!=NULL branch (nock_ex at runtime)
(b) Memo hit via distribution — [f.f] formula where both arms are
the same op2; first scan populates g_memo, second gets a hit
(c) DS2 with non-constant subject formula — p=[4 [0 1]] (inc)
yields wildcard sock, cook_find_jet skips, nock_ex fallback
(d) DS2 with resolved formula containing op7 — deep fresh-scan
recurses into a double-inc compose; tests non-trivial resolved
formula path
Also update ROADMAP.md (stage 7c/7d/7h descriptions, test count to
411) and AGENTS.md (test count, next priorities).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 4 tests covering the op2 partial eval sub-cases that were previously untested, plus doc updates.
The 4 op2 sub-cases now tested
ska op2: I2 fallback via SKNOCKrun_nomm1q≠NULL branchska op2: memo hit via distribution[f.f]where both arms are the same op2 → g_memo hit on second scanska op2: DS2 inc subject formula[4 [0 1]](inc) gives wildcard sock → cook_find_jet returns NULL → nock_ex fallbackska op2: DS2 resolved to op7 (double-inc)[7 [4 [0 1]] [4 [0 1]]]→ deep fresh-scan through op7Docs
ROADMAP.md: stage 7c/7d/7h entries updated; test count → 411AGENTS.md: test count → 411; next priorities trimmed (hardening sprint is complete)Result