Conversation
- Add -m 2G to all QEMU invocations (raspi4b requires exactly 2GiB RAM) - boot_pill() and boot_pill_event42() send 'KERNEL\n' after boot (cold_start → word_quit; KERNEL must be typed explicitly) - Increase timeouts: boot_pill 8s, boot_pill_event42 10s - Fix set -e abort: [[ VERBOSE ]] && cmd || true in check() - pill_load: revert to simple qnbytes>0 check (no magic sentinel) - mkpill.py: revert to PILL v2 format (no TRNT magic bytes) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 4 failing kernel-boot integration tests.
Root Causes
QEMU raspi4b requires
-m 2G— without it,PILL_BASE(0x10000000 = 256MB) is inaccessible. Added to all QEMU invocations inMakefile,tests/kernel-boot.sh, andtests/run_tests.sh.KERNELmust be typed explicitly —cold_startpoints toword_quit, notword_kernel. Updatedboot_pill()andboot_pill_event42()helpers to sendKERNEL\nafter boot.set -e+[[ VERBOSE ]] && cmd— whenVERBOSE=0, the&&short-circuits with exit code 1, aborting the script after the first test. Fixed with|| true.pill_loadreverted to simpleqnbytes > 0check — the magic sentinel approach crashed when accessingPILL_BASEthrough a C function (QEMU raspi4b memory quirk).Result
All 376 REPL tests continue to pass.