Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: Custom field styleguide #1487

Closed
wants to merge 8 commits into from
Closed

Forms: Custom field styleguide #1487

wants to merge 8 commits into from

Conversation

bettiifr
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: 81e5615

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

New version of the docu included, but commented out
Copy link
Collaborator

@kathrinschalber kathrinschalber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bettiifr good work, I like the overview that we can use then. Foremost consistency and some minor writing topics, and I know that the custom field is not easy - so again, good work!

![Custom field](https://www.figma.com/design/wEptRgAezDU1z80Cn3eZ0o/iX-Pattern-Illustrations?node-id=3303-3291&t=DlxXBQ9vTnyDcIUI-4 )

1. Label
2. Helper text/Feedback text
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why both? Also don't forget that it can be a tooltip too 😉

Added feedback
Edited file name, deleted Quick guide
Copy link

sonarcloud bot commented Sep 24, 2024

@AndreasBerliner
Copy link
Collaborator

Merged into: #1318

@danielleroux danielleroux deleted the docs/forms/custom branch September 25, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants