-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(checkbox-group): fixed checkbox scroll issue #1362
Conversation
|
Report of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If display: none
is the solution here, everything else in the same selector will be obsolete, is it not?
remain parts can stay as it is. only input component should have been fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also apply the same change to the radio button styling. Thanks 🙏
@@ -23,6 +23,7 @@ | |||
min-width: 0px; | |||
overflow: hidden; | |||
position: absolute; | |||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be the better solution since this will allow a screen reader to still access the input element
display: none; | |
visibility: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ridvandmrc could you please take anther look at my comment so we can finalise the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After additional research we realized that both versions will remove the element from the a11y tree. This could be a problem for users relying on screen reader technology.
We resolved this issue here in #1527 with a focus on accessibility, as just hidding the checkbox makes the keyboard navigation difficult. |
💡 What is the current behavior?
When using a scrollable list of checkboxes in combination with ix-content, after scrolling and checking a checkbox that is at the bottom of the list, the content jumps up.
GitHub Issue Number: #1308
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support