Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox-group): fixed checkbox scroll issue #1362

Closed
wants to merge 2 commits into from

Conversation

ridvandmrc
Copy link
Contributor

💡 What is the current behavior?

When using a scrollable list of checkboxes in combination with ix-content, after scrolling and checking a checkbox that is at the bottom of the list, the content jumps up.

GitHub Issue Number: #1308

🆕 What is the new behavior?

  • the input that was used as place holder hide the input

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: d5e991e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

Total errors are the same in both branches

ESLint check

Total ESLint warnings are the same in both branches

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If display: none is the solution here, everything else in the same selector will be obsolete, is it not?

@ridvandmrc
Copy link
Contributor Author

If display: none is the solution here, everything else in the same selector will be obsolete, is it not?

remain parts can stay as it is. only input component should have been fix

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also apply the same change to the radio button styling. Thanks 🙏

@@ -23,6 +23,7 @@
min-width: 0px;
overflow: hidden;
position: absolute;
display: none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be the better solution since this will allow a screen reader to still access the input element

Suggested change
display: none;
visibility: hidden;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ridvandmrc could you please take anther look at my comment so we can finalise the PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After additional research we realized that both versions will remove the element from the a11y tree. This could be a problem for users relying on screen reader technology.

@matthiashader
Copy link
Collaborator

We resolved this issue here in #1527 with a focus on accessibility, as just hidding the checkbox makes the keyboard navigation difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants