fix: skip SNI for IP addresses in TLS connection #3835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting using TLS there is an optional field,
servername
, for setting the Server Name Indication (SNI) but this field only makes sense to set if we are using a hostname to connect and not an IP. Since v12 of Node.js, it's been deprecated to provide an IP address as the SNI so it will be ignored at some point anyway.This PR prevents setting
servername
in the TLS config if the MySQL confighost
field is an IP which in turn quiets this deprecation warning:The logic for setting SNI to the host was originally added in #1554.
Fixes #2588