Skip to content

bring back show folder#232

Merged
siddharthvaddem merged 1 commit intomainfrom
codex/saved-to-location
Mar 18, 2026
Merged

bring back show folder#232
siddharthvaddem merged 1 commit intomainfrom
codex/saved-to-location

Conversation

@siddharthvaddem
Copy link
Owner

@siddharthvaddem siddharthvaddem commented Mar 18, 2026

Pull Request Template

Description

Motivation

Type of Change

  • New Feature
  • Bug Fix
  • Refactor / Code Cleanup
  • Documentation Update
  • Other (please specify)

Related Issue(s)

Screenshots / Video

Screenshot (if applicable):

![Screenshot Description](path/to/screenshot.png)

Video (if applicable):

<video src="path/to/video.mp4" controls width="600"></video>

Testing

Checklist

  • I have performed a self-review of my code.
  • I have added any necessary screenshots or videos.
  • I have linked related issue(s) and updated the changelog if applicable.

Thank you for contributing!

Summary by CodeRabbit

  • New Features
    • Added a "Show in Folder" button that allows users to quickly locate and open their exported video files directly in the system file explorer immediately after export completes.
    • Improved error handling and messaging when showing exported files in the folder fails, providing users with clear feedback about what went wrong.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5b04616b-f4b4-4158-8c8e-518454c5ce20

📥 Commits

Reviewing files that changed from the base of the PR and between 0f12328 and 4b8c95f.

📒 Files selected for processing (2)
  • src/components/video-editor/ExportDialog.tsx
  • src/components/video-editor/VideoEditor.tsx

📝 Walkthrough

Walkthrough

This PR refactors the "Show in Folder" functionality by moving file reveal logic and state management from ExportDialog to VideoEditor. ExportDialog now accepts optional callbacks and file path data as props, while VideoEditor manages IPC communication, error handling, and exposes the reveal capability through a callback passed down to ExportDialog.

Changes

Cohort / File(s) Summary
Export Dialog Simplification
src/components/video-editor/ExportDialog.tsx
Added optional onShowInFolder callback prop and exportedFilePath prop. Removed internal handleClickShowInFolder function and toast-based error handling. "Show in Folder" button now delegates to external callback.
Video Editor State & Callback Management
src/components/video-editor/VideoEditor.tsx
Added exportedFilePath state to track recently exported files. Introduced handleShowExportedFile (IPC-based file reveal with error handling) and handleExportSaved (state update with toast action). Integrated callbacks into export flow: clear state at export start, reset on cancel, and pass handlers to ExportDialog.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hops through folders with glee,
The burden moves, now light and free,
VideoEditor takes the reins,
Dialog rests—callbacks sustain,
Files revealed with IPC's dance,
Refactored in perfect stance! 🌟

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/saved-to-location
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

@siddharthvaddem siddharthvaddem merged commit 7a6efc5 into main Mar 18, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant