feat: replace motion blur toggle with intensity slider#221
Merged
siddharthvaddem merged 3 commits intosiddharthvaddem:mainfrom Mar 16, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 293d8bd62c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Motion blur was a boolean switch (on/off). This changes it to a slider from 0 (off) to 1 (full intensity), with 0.35 as the recommended sweet spot per feedback on PR siddharthvaddem#207. - EditorState/ProjectEditorState: motionBlurEnabled:bool → motionBlurAmount:number - SettingsPanel: Switch → Slider (0–1, step 0.01); shows 'off' or value - VideoPlayback/zoomTransform: scale blur by amount instead of boolean gate - FrameRenderer/VideoExporter/GifExporter: propagate numeric amount - projectPersistence: backward-compat loader (old true → 0.35, false → 0)
EtienneLescot
force-pushed
the
feat/motion-blur-slider
branch
from
293d8bd to
dd84eda
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #207 (comments by @siddharthvaddem and @webadderall).
Problem
Motion blur was a boolean toggle (on/off), but the actual quality depends heavily on the intensity value. The default of
0.35gives the best result per @webadderall's testing, but users had no way to tune it.Changes
0shows as off, anything above shows the numeric value (e.g.0.35)amount * motionIntensity * 120, capped at 6px — same formula, now user-tunablemotionBlurEnabled: trueload as0.35,falseloads as0Files changed
useEditorHistory.tsmotionBlurEnabled: bool→motionBlurAmount: numberprojectPersistence.tsSettingsPanel.tsxVideoEditor.tsxVideoPlayback.tsxzoomTransform.tsbool→number, blur scales by amountframeRenderer.tsbool→numbervideoExporter.tsbool→numbergifExporter.tsbool→number