feat: add cursor overlay pipeline (depends on #207)#217
Draft
EtienneLescot wants to merge 3 commits intosiddharthvaddem:mainfrom
Draft
feat: add cursor overlay pipeline (depends on #207)#217EtienneLescot wants to merge 3 commits intosiddharthvaddem:mainfrom
EtienneLescot wants to merge 3 commits intosiddharthvaddem:mainfrom
Conversation
3 tasks
b94ffca to
a5d52d8
Compare
36081e4 to
e8e6a95
Compare
Owner
|
Just wanted to thank you for working on this and helping contribute to the project 🙏 I know this is a draft, but wanted to reiterate that I was never against Native Capture. We can have the cursor related settings hidden for Linux and Windows. If that helps. Let me know if there's any further clarification needed. Sorry if this feels like going back and forth Had a couple of folks on X reach out and say they really wanted this for macOS. No rush on this at all. Don't feel obliged. This is a pretty large change which would require a lot of testing to avoid bugs. This is what usually helps me (might have missed something): Capture + Launch
Audio
Editor Load + Playback
Timeline
Project Persistence
Other
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follow-up depends on #207.
GitHub cannot target
feat/recordly-cursor-pipelineas the PR base here because that branch exists only on my fork, so this PR still points atmain. In practice, the intended review order is:Included in this PR
Cursor overlay rendering
Cursor editor controls
Cursor project data
Main files
src/components/video-editor/SettingsPanel.tsxsrc/components/video-editor/VideoEditor.tsxsrc/components/video-editor/VideoPlayback.tsxsrc/components/video-editor/videoPlayback/cursorRenderer.tssrc/components/video-editor/videoPlayback/motionSmoothing.tssrc/components/video-editor/videoPlayback/uploadedCursorAssets.tsNotes
./node_modules/.bin/tsc --noEmitandnpm exec vite build