Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/card-flickering: Fix card flickering on hover #1113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahsansheikh94
Copy link

@ahsansheikh94 ahsansheikh94 commented Aug 25, 2024

Description

Fixes: Issue #1095 where the card flickers whenever you hover over the skills list.

Related Issues

When the user hovers over the skills list on a card, the height of the card changes creating a weird flickering effect.

Changes Proposed

The issue was occurring because there was a scrollbar being added to the view whenever we hover over it since the overflow is hidden by default and upon hovering it changes to scroll, adding a scrollbar.
Made it so that the overflow is auto by default.

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screen.Recording.2024-08-25.at.11.39.47.PM.mov

Note to reviewers

This is my first time contributing to open source, sorry if I missed something :)

Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 6:42pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ahsansheikh94! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@ahsansheikh94 ahsansheikh94 changed the title Fix card flickering on hover fix/card-flickering: Fix card flickering on hover Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant