Skip to content

Multiple improvements (see description)#7

Open
Siko91 wants to merge 1 commit intoshruggr:masterfrom
Siko91:patch-1
Open

Multiple improvements (see description)#7
Siko91 wants to merge 1 commit intoshruggr:masterfrom
Siko91:patch-1

Conversation

@Siko91
Copy link

@Siko91 Siko91 commented Aug 8, 2019

Multiple improvements:

  • BitBtn funding of the address,
  • BitBtn value gets updated automatically when a file is selected.
  • Changed style a bit to look good on mobile,
  • public key is now a whatsonchain link,
  • private key has a QR code too

Multiple improvements:
- BitBtn funding of the address,
- BitBtn value gets updated automatically when a file is selected.
- Changed style a bit to look good on mobile,
- public key is now a whatsonchain link,
- private key has a QR code too
@shruggr
Copy link
Owner

shruggr commented Aug 8, 2019

Can BitBtn source be saved and linked as a B or BCAT transaction id? As implemented, this will not work with Bottle since githack is not in the trusted sources.

@Siko91
Copy link
Author

Siko91 commented Aug 9, 2019

It can.
But it is still changing quite often.
It will quickly get outdated.
How about a D:// link?

Also - I never actually tested if it even works from Bottle.
It is hard to test, because no desktop wallet supports BitBtn's OutputURI yet.

@shruggr
Copy link
Owner

shruggr commented Aug 9, 2019

To be honest, I'm not even sure that the base functionality even works with bottle any more, but this wallet is not really safe in a regular browser. Any page served over bico.media can access your keys how it is currently implemented

@Siko91
Copy link
Author

Siko91 commented Aug 10, 2019

It is safe enough in a regular browser if it provided from our own websites, and not from bico.

There are still possible risks (XSS), but considering that this wallet is not really intended for holding of money, I believe it is safe enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants