Repository navigation
chore: Nx 24, Node 26.13, Babel 8 and pako 3, plus dead-code cleanup - #612
Merged
Merged
Conversation
Run the official Nx 24 migrations. The removed @nx/storybook executors become @nx/storybook/plugin inferred targets with the same names, ports, output directories and sync-catalog-assets dependencies. Inferred inputs default to the production set, which excludes stories and .storybook/**, so build-storybook keeps default inputs to invalidate on story changes. viteConfigPath now resolves from the config file because inferred tasks run in the project root. affected.legacy keeps the gate's project scope.
Agents' Rolldown Babel bridge accepts @babel/core 8 and Vite React 6 no longer uses Babel, so the Agents decorator override to Babel 7 goes; Nx keeps its own nested Babel 7. Delete the axios override, which no longer matches any locked package. Cover the KaTeX override with a rendered display-math and unknown-command check through MessageResponse.
Select pako's classic zlib hash so share payloads stay byte-identical to the recorded Excalidraw fixture; pako 3 defaults to a faster hash that changes the output. pako ships its own types, so @types/pako goes.
No importer, manifest, route or Storybook glob reads the Icons, Web or Excalidraw src/index.ts barrels. CodeExampleSchema, CodeModeSearchHitSchema and MAX_SHARE_ID_LENGTH have no consumers; the share-id regex still bounds ids at 128.
Remove the one-shot cutover inventory, retired-identifier scans and runbook prose checks, keeping the public-domain and Wrangler exposure cases. Drop CLI audit cases that parse cli.ts or document.ts spelling or repeat version pins; built-help and document tests cover them. Drop the retired Playground lib path ban, route import spelling and line cap, the any-laundering limitation pin, and CSS/font substring tests that cannot show which rule renders.
…pty mobile chrome A read-only scene canvas fit only on first load, so loading wide and narrowing to a phone kept the wide zoom and clipped every node after the first. It now refits whenever Excalidraw reports a new viewport size; editable canvases still keep the user's camera. The empty read-only mobile menu and bottom bar are hidden at every width, not only in containers 700px and wider.
@streamdown/math renders KaTeX but the Playground never loaded its CSS, so formulas showed their screen-reader MathML beside unstyled HTML. Import katex/dist/katex.min.css at the app stylesheet, declaring KaTeX 0.19.1 directly so the import resolves. A Browserbase check renders inline, display and invalid TeX through MessageResponse.
The Nx 24 Storybook plugin always infers static-storybook with @nx/web:file-server and the project's own storybook-static directory. Add @nx/web 24.0.3 and point each target at the configured output directory so it serves the built Storybook.
anandpant
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Sketchi Web PreviewStatus:
|
Contributor
Sketchi Icons PreviewStatus:
|
Contributor
Sketchi Eval Harness PreviewStatus:
|
Contributor
Sketchi Excalidraw Workspace PreviewStatus:
|
Contributor
Sketchi Playground / Studio PreviewStatus:
|
Hiding the whole read-only mobile bottom bar also hid Excalidraw's Scroll back to content button, so a phone user who panned the diagram away was left with a blank canvas. Hide the bar only while it has no recovery button, and then show the button alone. A Browserbase check pans a 390px read-only canvas away and recovers through the button.
At 390px the artifact and editor headers wrapped into three rows: the lockup alone, the route with its actions, then Docs and GitHub. On phones a route with actions now takes a second full-width row, links left and actions right, under the lockup and Docs/GitHub. Link-only headers and desktop keep one row. At 320px the header tightens its padding and icon gaps so a route link and five actions fit. A Browserbase check measures the rows at 320, 390 and 1280 with Hanken Grotesk and Excalifont loaded.
Collaborator
Author
Merge activity
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the toolchain to the current stable lines, finishes the dependency migrations an earlier slice had deferred, and removes dead packages, code and tests.
Toolchain and Nx
latesttag; 12.17.0 is onlynext-12). Pins inmise.toml,package.jsonengines/packageManager, the lockfile and README move together; no Corepack.@nx/storybookexecutors, so the ten Storybook targets are now@nx/storybook/plugininferred tasks with the same names, ports, output directories and Iconssync-catalog-assetsdependency.build-storybookkeeps default inputs: the inferred production set excludes stories and.storybook/**, which would have served stale cached builds.affected.legacykeeps the local gate's project-level scope.static-storybooktargets that use@nx/web:file-server, so@nx/web24.0.3 is added and each target serves that project's configured Storybook output.@nx/plugin,@nx/react,@nx/viteand@nx/vitest.Dependencies
legacyHash: trueso encrypted payloads stay byte-identical to the recorded Excalidraw fixture (the fixture test fails without it).@types/pakoremoved; pako ships types. CLI patch changeset included.Fixes
Chat math. The Playground never loaded KaTeX's stylesheet, so formulas in chat and reasoning messages showed their screen-reader MathML beside unstyled HTML. It now imports
katex/dist/katex.min.css; a Browserbase test renders inline, display and invalid TeX.Canvas resize.
Read-only scene canvases (Playground sample, Storybook) now refit when their viewport resizes; previously loading wide and narrowing to a phone kept the wide zoom and clipped the diagram. Editable canvases still keep the user's camera. Empty read-only mobile controls are hidden, while panning off-screen reveals the working Scroll back to content recovery button. A Browserbase regression covers hiding, hit-testing and recovery.
Phone headers. Dense artifact/editor headers use two aligned rows at 320/390px: brand plus Docs/GitHub, then existing route links and actions. Compact home headers and desktop layouts stay one row. Browserbase checks wait for the real Hanken Grotesk and Excalifont faces before measuring. No controls or copy were added.
Deletions
Unused Icons/Web/Excalidraw
src/index.tsbarrels and three unconsumed exports; one-shot cutover inventory and runbook prose tests (public-domain exposure checks kept); CLI audit cases that parsed source spelling or repeated version pins (built-help and document tests cover them); Playground retired-path and route-spelling checks; CSS/font substring tests.Verification
pnpm ci:localgate, Excalidraw and Playground Browserbase suites, all five Storybook builds uncached and served throughstatic-storybook, CLI package smoke and bundle report, Worker dry runs, headless Storybook resize check. Independent Codex gpt-6.1-sol high review covered the full patch and both follow-ups. The one mobile recovery finding was fixed and independently re-reviewed.Real preview proof: icon search/multi-select/palette and a two-SVG ZIP; generation of an exact three-step native diagram; save/reload; edit/export with all eight elements moved; actual styled chat math; authless Icons and Playground MCP tool calls; mobile resize and pan/recenter. Final preview at
970a09ca: all nine combinations of homepage/artifact/editor and 320/390/1280px passed loaded-font, row-count and clipping checks; screenshots inspected. All five preview deploys passed. After merge: all five production deploys passed, both MCP endpoints passed real tool calls, and Playground generation/download, styled math, phone header and pan/recenter recovery passed live. CLI0.31.6is npm latest; the published tarball integrity, executable/bin mapping, Pako 3.0.3 notices, version and share help were verified. Main is clean and the owned worktree/branch, servers and browsers are cleaned up.