Dataloader optimisation - #20
Open
0xtristan wants to merge 3 commits into
Open
Conversation
0xtristan
commented
Mar 7, 2021
0xtristan
commented
Collaborator
- mapping transform BEFORE windowing
- var seq lens and goal tiling are computationally expensive (we ought to do on device) so I've removed from dataloader
- multi-threaded tfrecords mapper (NOT the IO, this has to be single threaded)
- action validation also taxing, it could be risky removing but it's also too slow. We should validate our data once off beforehand
added 3 commits
March 8, 2021 08:27
- var seq lens and goal tiling are computationally expensive (we ought to do on device) so I've removed from dataloader - multi-threaded tfrecords mapper (NOT the IO, this has to be single threaded) - action validation also taxing, it could be risky removing but it's also too slow. We should validate our data once off beforehand
tristanheywood
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.