Fixes security HUDs so that they show job icons again#6351
Open
zimon9 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR changes the define for security huds so that they're an integer again, as job icons weren't showing up when a string entry was used for them instead
Why It's Good For The Game
I know the solution is kind of terrible, but I tried to dig deep into the problem and I got as far as figuring out that hud_atoms weren't being added when the list entry was a string, but they were being added when the entry was an integer. What's especially confusing is that, during debugging, I found that byond correctly loaded the right hud datum regardless of what the entry was, be it a string or an integer. It's just the fact that hud_atoms aren't being added for this datum unless its entry is given as an integer.
Changelog
🆑
fix: fixed hud job icons so that they show up again
/:cl: