Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to angular 16 #1932

Merged
merged 2 commits into from
Jul 11, 2023
Merged

update to angular 16 #1932

merged 2 commits into from
Jul 11, 2023

Conversation

tomer953
Copy link
Contributor

a new PR with latest angular 16.1.4

This was referenced Jul 10, 2023
Closed
Closed
@RobbieTheWagner
Copy link
Member

@tomer953 looks like tests are failing because we need to update node

@tomer953
Copy link
Contributor Author

tomer953 commented Jul 10, 2023 •
edited
Loading

@tomer953 looks like tests are failing because we need to update node

yes i see, sorry about that.
do you want me to create a fix? ill do tomorrow

I think it is just this line:

angular-shepherd/package.json

Line 59 in 229a3f2

"node": "16.13.1"

right?

@tomer953
Copy link
Contributor Author

try now ?

@RobbieTheWagner RobbieTheWagner merged commit 940421b into shipshapecode:main Jul 11, 2023
2 checks passed
@tomer953
Copy link
Contributor Author

tomer953 commented Jul 11, 2023 •
edited
Loading

thank you.
plz don't forget to publish to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomer953 @RobbieTheWagner