Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opaque panel mode for light theme #349

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −3
Open

Added opaque panel mode for light theme #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43fcfa2
Added opaque panel mode for light theme
rc-05 Oct 26, 2024
f287ba8
Added opaque panel mode for light theme
rc-05 Oct 26, 2024
e61d920
Update meson.build
rc-05 Oct 26, 2024
c2f4689
Merge branch 'opaque-panel-light-theme' of https://github.com/rc-05/G…
rc-05 Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion light/gtk-3.0/_xfce.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
$variant: 'light';
$opaque_panel: false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of variable opaque_panel should be written in all lowercase letters with hyphens instead of underscores


@import 'colors';

Expand All @@ -13,7 +14,7 @@ $variant: 'light';
}

.xfce4-panel.background {
background-color: rgba(36, 36, 36, 0.8);
background-color: rgba(36, 36, 36, if($opaque_panel, 1, 0.8));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 2 spaces, but was indented 4 spaces
Name of variable opaque_panel should be written in all lowercase letters with hyphens instead of underscores

color: $panel_fg_color;
font-weight: normal;
button {
Expand Down
9 changes: 8 additions & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,11 @@ if get_option('flatpak')
else
subdir('light')
subdir('dark')
endif
endif

if get_option('opaque-panel-light-theme')
run_command('sed', '-i', '"s/\$opaque_panel: false;/\$opaque_panel: true;/"', meson.source_root() + '/light/gtk-3.0/_xfce.scss')
message('Panel transparency with light theme: opaque')
else
message('Panel transparency with light theme: semi-transparent')
endif
3 changes: 2 additions & 1 deletion meson_options.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
option('generate_sourcemaps', type: 'boolean', value: false)
option('flatpak', type: 'boolean', value: false)
option('flatpak-variant', type: 'combo', choices : ['light', 'dark'], value: 'light')
option('flatpak-variant', type: 'combo', choices : ['light', 'dark'], value: 'light')
option('opaque-panel-light-theme', type: 'boolean', value: false)