feature: add preferredTime

[duduz]

this feature can get a better user preference by allowing them to select a preferred time.
this doesn't guarantee anything, but if availability allows, it'll schedule according to this preference

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[drorgh]

I think it makes more sense to provide a time range, in which an appointment can be scheduled, rather than a single time point. #1

[duduz]

@drorgh in a perfect utopia, certainly.
but i am quite familiar with how the API behaves and the current availability, it's better to set a preference.
99% of the time, that preference will not be fulfilled (not enough availability) so the best you can do there is to get the closest appointment to your preference 😊

the current situation is - 3 appointments have been found, 08:12, 10:00 and 12:00, you'll get the first one.
with this proposed change, if you select 09:30, you'll get 10:00

[drorgh]

@duduz if preferredTime will be ignored most of the time anyway, wouldn't it be better not the set it at all, and just filter the results according to a specified time range? (in your example, if my range is 11:30-14:00, I can make it only to the 12:00 appointment)

[duduz]

@drorgh why would it be ignored? you have to select a preferred time in order to start searching.
and.. no. at the current situation you want an appointment even if it doesn't suit you best. it's really a "take what's available" situation.

[drorgh]

👍