Skip to content

feat: add UI indication for state transitions - #32

Open
naorpeled wants to merge 1 commit into
shilomagen:mainfrom
naorpeled:feat/add-search-ui-indication
Open

feat: add UI indication for state transitions#32
naorpeled wants to merge 1 commit into
shilomagen:mainfrom
naorpeled:feat/add-search-ui-indication

Conversation

@naorpeled

@naorpeled naorpeled commented Apr 29, 2023

Copy link
Copy Markdown

Description

Closes #15

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Green path:

  • logged into myVisit.com, searched for an appointment

Red path:

  • logged out and tried to search for an appointment

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@naorpeled
naorpeled marked this pull request as draft April 29, 2023 17:23
@naorpeled
naorpeled marked this pull request as ready for review May 26, 2023 21:02
@naorpeled
naorpeled marked this pull request as draft May 26, 2023 21:02
@naorpeled
naorpeled force-pushed the feat/add-search-ui-indication branch from 3c72303 to 81a7567 Compare May 26, 2023 21:25
@naorpeled
naorpeled marked this pull request as ready for review May 26, 2023 21:38
naorpeled added a commit to naorpeled/passport-extension that referenced this pull request May 27, 2023
@naorpeled
naorpeled force-pushed the feat/add-search-ui-indication branch 2 times, most recently from 8b94547 to 0934c39 Compare May 27, 2023 18:51
@naorpeled
naorpeled force-pushed the feat/add-search-ui-indication branch from 867523d to 370a5e6 Compare May 27, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Search status indication on Gamkenbot icon

1 participant