[WIP] SignalingChannelImpl の disconenct の返り値を SignalingDisconnectResult? に変更する #157
+88
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the behavior of SignalingChannelImpl's disconnect method to return a SignalingDisconnectResult? by capturing code and reason from the WebSocketListener.onClosed callback.
- Waits up to 5 seconds for the onClosed callback before timing out
- Returns a SignalingDisconnectResult when code and reason are available, otherwise returns null
Reviewed Changes
| File | Description |
|---|---|
| CHANGES.md | Updated change log entries to reflect changes in disconnect behavior |
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
|
#156 を develop にマージしたあとにレビューリクエスト予定です |
Co-authored-by: Copilot <[email protected]>
…nnect' of https://github.com/shiguredo/sora-android-sdk into feature/onclosed-code-reason-signalingchannelimpl-disconnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disconenctの返り値をSignalingDisconnectResult?に変更するWebSocketListener.onClosedで取得できる code と reason をSignalingDisconnectResultに格納して返すようにした