Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp4MediaStream の対応コーデックに VP8 を追加する #508

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

sile
Copy link
Member

@sile sile commented Dec 6, 2024

Copilot Summary

This pull request includes several changes to the Mp4MediaStream library to add support for the VP8 codec and improve error handling during video and audio decoding. The most important changes include updates to the codec support, enhancements in error handling, and modifications to the WASM module to support VP8.

Codec Support Updates:

  • Added VP8 codec support to Mp4MediaStream in CHANGES.md and packages/mp4-media-stream/README.md. [1] [2]

Error Handling Improvements:

  • Improved error handling in Mp4MediaStream by ensuring frame.close() and data.close() are called in finally blocks to prevent resource leaks. [1] [2]

WASM Module Modifications:

  • Added Vp08Box to the list of supported boxes in packages/mp4-media-stream/wasm/src/mp4.rs.
  • Implemented from_vp08_box method in VideoDecoderConfig to create configurations from VP8 boxes.
  • Updated Track and Mp4 implementations to handle VP8 sample entries. [1] [2]
  • Modified TrackPlayer to create video decoders for VP8 sample entries.

@sile sile merged commit 8093dc4 into develop Dec 6, 2024
2 checks passed
@sile sile deleted the feature/mp4-media-stream-vp8 branch December 6, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant