Shetabit master #291
Shetabit master #291
Conversation
Replaced the HTTP client code with cURL to handle API requests for the Zibal payment gateway. The change aims to streamline the request process, encapsulating the data and headers setup within the cURL functions.
This change removes the client object and switches to using cURL for handling the payment verification process. The updated implementation uses direct cURL functions to set the request parameters and handle the response, streamlining the verification process. Additionally, the `orderId` variable was removed as it was unused.
Replaced verbose cURL initialization with a streamlined approach using parameter arrays and JSON encoding. This improves readability and maintainability while preserving functionality. Added `ext-curl` dependency in composer.json to ensure required PHP extensions are declared.
Cleaned up redundant `@throws` annotations for GuzzleException in the `purchase` and `verify` methods. This improves code readability and maintains alignment with current code behavior.
Changed the return type from string to RedirectionForm in the redirectWithForm method of the Driver class. This ensures better type safety and clarity in the codebase.
|
سلام امکانش هست یه توضیح در اینکه چی شد از guzzle به curl تغییر داده شد بدین🙏...(#283) باگ امنیتی چیزی برای guzzle گزارش شده؟ (برای اطلاعات خودم میخوام) |
|
@alissn |
|
من توکن برای تست کردنش ندارم. ارور خاصی میداد؟ یا اتفاق خاصی تو روند ارسال به درگاه می افتاد؟ تا جایی که من میدونم از این پکیج برای پروژه های غیر لاراولی هم استفاده میشه، بهتره که این روند حفظ بشه... البته که تصمیم گیرنده اصلی آقا مهدی هستن. @khanzadimahdi |
|
@alissn |
|
هر کدی به اقتضای زمان خودش داره کار میکنه، نمیشه گفت تست نمیشه... به هر حال من متوجه دلیل تغییرش نشدم... |
|
لطفا کانفلیکت ها رو رفع کنید. الان کانفلیکت خورده و نمیشه مرج کرد. |
|
شما از روی این برنچ PR ساختین روی fork خودتون. باید خودتون اونو resolve کنید و مرج کنید. |
Description
Describe your changes in detail.
Motivation and context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here (if you write
fixes #numor
closes #num, the issue will be automatically closed when the pull is accepted.)How has this been tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!