Suppress intentional global constructor warning - #184
Merged
Conversation
🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6
Includes the Clang padding warning fix from sheredom/subprocess.h#99. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6
sheredom
added a commit
to sheredom/subprocess.h
that referenced
this pull request
Jul 20, 2026
Includes the intentional global constructor warning fix from sheredom/utest.h#184. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6
Includes the macOS 26 spawn chdir compatibility fix from sheredom/subprocess.h#99. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6
Includes the strict clang-cl C compatibility fix from sheredom/subprocess.h#99. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6
Includes the clang-cl TLS warning fix from sheredom/subprocess.h#99. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6
sheredom
added a commit
to sheredom/subprocess.h
that referenced
this pull request
Jul 20, 2026
* Suppress intentional Windows struct padding warnings 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6 * Update vendored utest.h Includes the intentional global constructor warning fix from sheredom/utest.h#184. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6 * Support the standardized macOS spawn chdir action Use posix_spawn_file_actions_addchdir for macOS 26 deployment targets and suppress the intentional deprecation warning when retaining the backward-compatible _np API. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6 * Avoid wchar_t C++ keyword compatibility warnings Use an internal wide-character alias so strict clang-cl C builds only need to suppress the compatibility warning at the intentional wchar_t typedef. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6 * Suppress intentional TLS object duplication warning The named-pipe counter is intentionally local to each header-library instance. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6 * Ignore Windows SDK enum migration warnings MSVC 2026 emits C4865 from Windows SDK headers under /Wall; suppress that external-header warning in the test build. 🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wglobal-constructorsdiagnostics in test registration macrossubprocess.hwith the toolchain compatibility fixes from Fix strict builds with current toolchains subprocess.h#99Testing
git diff --check🧙 Conjured by AI via pi.dev using gpt-5.6-sol