Skip to content

Use Unicode process creation on Windows - #97

Merged
sheredom merged 1 commit into
mainfrom
fix-windows-utf8-createprocess
May 24, 2026
Merged

Use Unicode process creation on Windows#97
sheredom merged 1 commit into
mainfrom
fix-windows-utf8-createprocess

Conversation

@sheredom

Copy link
Copy Markdown
Owner

Summary

  • switch Windows process creation from CreateProcessA to CreateProcessW
  • convert command lines, custom environment blocks, and process CWD from UTF-8 to UTF-16 before spawning
  • document Windows UTF-8 handling for command lines, environments, and CWD

Closes #68.

Tests

  • cmake --build build && (cd build && ./subprocess_test)
  • (cd build && ./subprocess_mt_test)
  • cmake -S test -B /tmp/subprocess-clang2 -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug && cmake --build /tmp/subprocess-clang2 && (cd /tmp/subprocess-clang2 && ./subprocess_test)
  • (cd /tmp/subprocess-clang2 && ./subprocess_mt_test)

🧙 Conjured by AI via pi.dev using gpt-5.5

🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.5
@sheredom
sheredom merged commit b0c3e4f into main May 24, 2026
24 checks passed
@sheredom
sheredom deleted the fix-windows-utf8-createprocess branch May 24, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unicode support on Windows?

1 participant