-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add craft night, change some words, and make calendar "importable" #71
Conversation
Looks good but could we remove the emojis and the (craft night). It looks a bit odd if the other nights aren’t specific and I don’t want to limit prospective members who may not come down that night if it’s not crafts they do. Emojis are also a bit problematic for older devices and screen readers plus it looks a bit unprofessional in my opinion. |
I don’t see any issues on mobile (chrome IPhone 14) |
I have removed the emoji Here are some experiments with different looks I have left it as the first one. Again, see on http://shhm.alifeee.co.uk/
I apologise for my directness, but I do not think this will happen at all. Thanks. |
also, thanks for testing on mobile. I have also done so. thusly, removing draft status :) |
updated, reformatted the new content please see updated images above in original comment or browse on http://shhm.alifeee.co.uk/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, all makes sense.
Sorry only trustees should be able to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me
Sorry only trustees should be able to approve
@alifeee, The trustees, have suggested the wording |
Oh and can we update it to the 2 weeks were not running wednesday. |
hi @LouiseMcMahon thanks for the review your comments seem to me to reference the old suggestions, i.e., the addition of " This is no longer how this change is formatted. For example, I have already added a change to clarify that open night with craft focus is running only twice a month. You can see the current suggestion on http://shhm.alifeee.co.uk/ or in the screenshots at the top of this PR. If you already saw the updated suggestion, then I misunderstand your request. Could you clarify which section you desire to be changed ? thanks |
some updates to website, including:
_includes
folder, so that it can be included on multiple pages with{% include calendar.md %}
, and will stay up to date on those pages if changedPlease see the changes live on http://shhm.alifeee.co.uk/, or the comparison images here (see the file diff for a better idea of what has changed)
/
- current/
- new/calendar/
- current/calendar/
- new/joining/
- current/joining/
- new