Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add craft night, change some words, and make calendar "importable" #71

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

alifeee
Copy link
Member

@alifeee alifeee commented Jul 24, 2024

some updates to website, including:

  • add craft night (it has now run for 14 consecutive weeks, since April 24th 2024)
  • add some words to clarify that people can visit prospectively without becoming a member (I have heard some confusion over this)
  • move calendar to _includes folder, so that it can be included on multiple pages with {% include calendar.md %}, and will stay up to date on those pages if changed

Please see the changes live on http://shhm.alifeee.co.uk/, or the comparison images here (see the file diff for a better idea of what has changed)

/ - current

image

/ - new

image

/calendar/ - current

image

/calendar/ - new

image

/joining/ - current

image

/joining/ - new

image

@LouiseMcMahon
Copy link
Contributor

Looks good but could we remove the emojis and the (craft night). It looks a bit odd if the other nights aren’t specific and I don’t want to limit prospective members who may not come down that night if it’s not crafts they do.

Emojis are also a bit problematic for older devices and screen readers plus it looks a bit unprofessional in my opinion.

@LouiseMcMahon
Copy link
Contributor

I don’t see any issues on mobile (chrome IPhone 14)

@alifeee
Copy link
Member Author

alifeee commented Jul 28, 2024

I have removed the emoji

Here are some experiments with different looks

image

I have left it as the first one. Again, see on http://shhm.alifeee.co.uk/

I don’t want to limit prospective members who may not come down that night if it’s not crafts they do.

I apologise for my directness, but I do not think this will happen at all. Thanks.

@alifeee
Copy link
Member Author

alifeee commented Jul 28, 2024

also, thanks for testing on mobile. I have also done so.

thusly, removing draft status :)

@alifeee alifeee marked this pull request as ready for review July 28, 2024 22:48
@alifeee
Copy link
Member Author

alifeee commented Aug 23, 2024

updated, reformatted the new content

please see updated images above in original comment or browse on http://shhm.alifeee.co.uk/

@alifeee alifeee requested a review from LouiseMcMahon August 23, 2024 12:22
@neilzilla neilzilla self-requested a review August 23, 2024 12:25
neilzilla
neilzilla previously approved these changes Aug 23, 2024
Copy link

@neilzilla neilzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all makes sense.

@LouiseMcMahon LouiseMcMahon dismissed neilzilla’s stale review August 23, 2024 12:46

Sorry only trustees should be able to approve

neilzilla
neilzilla previously approved these changes Aug 23, 2024
Copy link

@neilzilla neilzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me

@LouiseMcMahon LouiseMcMahon dismissed neilzilla’s stale review August 28, 2024 18:48

Sorry only trustees should be able to approve

@LouiseMcMahon
Copy link
Contributor

@alifeee, The trustees, have suggested the wording (Open night with craft focus)

@LouiseMcMahon
Copy link
Contributor

Oh and can we update it to the 2 weeks were not running wednesday.

@alifeee
Copy link
Member Author

alifeee commented Aug 31, 2024

hi @LouiseMcMahon thanks for the review

your comments seem to me to reference the old suggestions, i.e., the addition of "- Wednesday 6pm - 9pm (craft night)".

This is no longer how this change is formatted. For example, I have already added a change to clarify that open night with craft focus is running only twice a month.

You can see the current suggestion on http://shhm.alifeee.co.uk/ or in the screenshots at the top of this PR.

If you already saw the updated suggestion, then I misunderstand your request. Could you clarify which section you desire to be changed ?

thanks

@LouiseMcMahon LouiseMcMahon merged commit 7d5be0f into main Sep 5, 2024
1 check passed
@alifeee alifeee deleted the update-words branch September 5, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants