refactor: developer tooling, bug fixes, and agent skills#38
Open
tombensim wants to merge 1 commit into
Open
Conversation
…rce readiness Add developer tooling: Makefile (setup/run/test/lint/format), pyproject.toml (ruff + pytest config), requirements-dev.txt, .pre-commit-config.yaml, and CI lint job with pip caching. Run ruff format across the codebase, fix 36 lint issues including bare excepts, unused imports/variables, and import ordering. Fix two bugs found during manual testing: - Assembly order was not persisted — backend now saves assembly_order to state in /assemble, new GET/POST /assembly_order endpoints added, and frontend restores assemblyOrder from state on page load - Trim updates did not sync back to in-memory state — adjustTrim() now assigns fetched state to global variable instead of a local Add 5 new tests (52 → 57) covering assembly order persistence and trim state consistency. Install 6 agent skills for contributors using Claude Code, Codex, Cursor, and other agents: flask, pytest, security-auditor, openai-whisper-api, requesting-code-review, and run-tests. Update CLAUDE.md with project structure, dev rules, and skills section. Update CONTRIBUTING.md with make commands, linting docs, and pre-commit instructions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make setup && make test && make linton day oneBug fixes detail
High — Assembly order not persisted:
/assemblenow savesassembly_ordertostate["assembly"]GET/POST /assembly_orderendpoints for direct accessassemblyOrderfromstate.assemblyon page loadrenderTimeline()syncsstate.assemblyon every mutationMedium — Trim state desync:
adjustTrim()now assigns fetched state to globalstateinstead of local variableTest plan
make lintpasses (ruff check + format)make testpasses — 57/57 tests green🤖 Generated with Claude Code