Skip to content

Add 6 new detectors from real-world 2026 incidents (v2.5.0) - #3

Merged
arena-ai-coding-agent[bot] merged 1 commit into
mainfrom
arena/01a03e5e-self-smart-contract-auditing-t
Aug 26, 2026
Merged

arena-ai-coding-agent[bot] merged 1 commit into
mainfrom
arena/01a03e5e-self-smart-contract-auditing-t

Conversation

@arena-ai-coding-agent

Copy link
Copy Markdown
Contributor

Summary

Drives the SELF auditing tool forward using concrete, citable 2026 real-world incidents and disclosures:

  • SOL-CRIT-015 — Low-level call result integrity: flags staticcall/call/delegatecall sites where the boolean success is discarded before the return data is decoded/compared. Generalizes the Gnosis Pay / Zodiac Roles & Delay module EIP-1271 bypass (June 2026, ~$1.5M loss).
  • SOL-CRIT-016 / SOL-HIGH-025 — Solidity --via-ir transient/persistent storage clearing collision ("TSTORE Poison", solc 0.8.28–0.8.33, fixed in 0.8.34): flags delete on a transient variable alongside a persistent value of a matching type in the same compilation unit under an affected/unpinned compiler version.
  • SOL-CRIT-017 — Unguarded oracle-shaped view (get_virtual_price, getRate, pricePerShare, …) with no reentrancy guard, enabling read-only reentrancy against downstream integrators.
  • SOL-CRIT-018 — EIP-712 domain separator sourced from a caller-supplied argument instead of derived on-chain from block.chainid/address(this).
  • SOL-HIGH-026 — Unconditional ERC-2612 permit() call in router functions with no try/catch + allowance fallback, enabling front-run griefing/DoS.

Detector catalog grows from 161 → 167 IDs, all with hardcoded review profiles (catalog ↔ profile parity preserved and gated by existing tests).

Also included

  • Positive + negative Solidity fixtures for each new detector (tests/contracts/*.sol, tests/contracts/negative/*.sol).
  • 8 new unit tests (5 in tests/test_new_detectors.py, 3 in tests/test_autonomous.py).
  • Knowledge-brain enrichment: 5 new AV-* attack-vector playbooks, 2 new incident post-mortems (INC-GNOSISPAY-ZODIAC-2026, INC-SOLC-TSTORE-POISON-2026), and a new dependency advisory (DEP-SOLC-TSTORE-POISON-2026) — all consumed by self train / self autonomous.
  • Dependency scanner now recognizes pinned solc + via_ir = true in foundry.toml and flags the TSTORE Poison compiler range.
  • 3 regex/logic bugs fixed in the new detector code discovered via live-fixture testing.
  • Version bumped to 2.5.0 (RULE_VERSION unchanged — additive, non-breaking for existing fingerprints).

Testing

  • python -m pytest tests/ -q → 159 passed, 0 failures.
  • Verified self train picks up the new brain entries.
  • Verified the dependency scanner correctly fires/doesn't fire on via-ir + solc version combinations.
  • Confirmed a pre-existing, unrelated runtime diagnostic (low_info_detectors.py AttributeError on ProxyStorageCollision.sol during a full-directory scan) predates this change (reproduced identically on main via git stash), so it's out of scope here.

…w reentrancy, domain-separator arg, permit front-run DoS) with fixtures, tests, and knowledge-brain enrichment; bump to 2.5.0

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@arena-ai-coding-agent
arena-ai-coding-agent Bot merged commit ebf1da7 into main Aug 26, 2026
5 of 6 checks passed
@sharthak18
sharthak18 deleted the arena/01a03e5e-self-smart-contract-auditing-t branch September 1, 2026 18:46
@sharthak18
sharthak18 restored the arena/01a03e5e-self-smart-contract-auditing-t branch September 1, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant