Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme_animalcrossing() #1

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add theme_animalcrossing() #1

wants to merge 14 commits into from

Conversation

Levi-Nicklas
Copy link

Sharla,

Check out my fork with the updated theme for Animal crossing! This is my first contribution to another person's project via fork & pull. If I made a mistake, let me know and I can fix it. 👍

  • Levi
    @Levi_Nicklas (twitter)

@sharlagelfand
Copy link
Owner

Hey @Levi-Nicklas, sorry it took me so long to get to this!! I have been... busy playing animal crossing 😊 It looks great! so cute.

just one thing that needs to be changed, you should be editing README.Rmd, not touching README.md directly. README.md is the result of knitting README.Rmd. Can you put the content you wrote into the .Rmd file and render it instead? It'll auto-generate all the required images and insert them in the right places in the .Md file so you don't have to worry about that!

you can just update your branch and push it and it'll update the pull request.

@Levi-Nicklas
Copy link
Author

No worries Sharla! I will make those edits at some point this week likely.

@Levi-Nicklas
Copy link
Author

I'm going to come back to this. Finishing out my last week of the semester & finals. Should have some time soon. 😄

@sharlagelfand
Copy link
Owner

no rush from me @Levi-Nicklas! good luck with your finals!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants