Skip to content

feat: mayachain ledger support#721

Merged
kaladinlight merged 4 commits into
masterfrom
mayachain-ledger
May 22, 2025
Merged

feat: mayachain ledger support#721
kaladinlight merged 4 commits into
masterfrom
mayachain-ledger

Conversation

@kaladinlight
Copy link
Copy Markdown
Contributor

No description provided.

@kaladinlight kaladinlight requested a review from a team as a code owner May 21, 2025 21:22
@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2025 9:20pm

@kaladinlight
Copy link
Copy Markdown
Contributor Author

Related update: shapeshift/proto-tx-builder#21

@gomesalexandre gomesalexandre self-requested a review May 22, 2025 08:20
Comment thread packages/hdwallet-ledger/src/mayachain.ts
gomesalexandre
gomesalexandre previously approved these changes May 22, 2025
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with verdaccio-published and the following in web:

diff --git a/src/context/WalletProvider/Ledger/constants.ts b/src/context/WalletProvider/Ledger/constants.ts
index 8a281166e6..e790b83c13 100644
--- a/src/context/WalletProvider/Ledger/constants.ts
+++ b/src/context/WalletProvider/Ledger/constants.ts
@@ -6,6 +6,7 @@ import {
   ethAssetId,
   fromAssetId,
   ltcAssetId,
+  mayachainAssetId,
   solAssetId,
   thorchainAssetId,
 } from '@shapeshiftoss/caip'
@@ -26,6 +27,7 @@ export const availableLedgerAppAssetIds = [
   ltcAssetId,
   ethAssetId,
   thorchainAssetId,
+  mayachainAssetId,
   cosmosAssetId,
   solAssetId,
 ]
  • Accounts are properly derived

https://jam.dev/c/eb6cba39-d298-4baa-87b6-08ae2bc7205d

  • Sends are happy

Note, balances are borked both in develop and this diff so had to monkey patch balance checks, as well as fees, however I'm getting this

image

With that being said, signing itself was happy so feeling pretty confident to stamp this!

@kaladinlight
Copy link
Copy Markdown
Contributor Author

Note, balances are borked both in develop and this diff so had to monkey patch balance checks, as well as fees, however I'm getting this

I am seeing issues as well, debugging what is up with the signature.

@kaladinlight
Copy link
Copy Markdown
Contributor Author

Note, balances are borked both in develop and this diff so had to monkey patch balance checks, as well as fees, however I'm getting this

I am seeing issues as well, debugging what is up with the signature.

Issue found and fix in flight

@kaladinlight kaladinlight merged commit 2b58185 into master May 22, 2025
4 checks passed
@kaladinlight kaladinlight deleted the mayachain-ledger branch May 22, 2025 21:42
@kaladinlight kaladinlight linked an issue Jun 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mayachain Support

2 participants