Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example in README #259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NiedziolkaMichal
Copy link

Following example doesn't work, because addValue has protected modifier:

policy.sandbox().get().addValue("allow-something-new");

Instead of removing it, it was replaced with usage of SandboxDirective.Value enum, that I've added in #258:

policy.sandbox().get().setValue(SandboxDirective.Value.AllowPopupsToEscapeSandbox, false);

Copy link
Contributor

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, assuming 258 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants