refactor: simplify calculator dispatch with variadic Set methods#18
Merged
Conversation
shanehull
force-pushed
the
feat/variadic-set
branch
from
July 23, 2026 07:38
55f208c to
6e0b299
Compare
shanehull
force-pushed
the
feat/variadic-set
branch
from
July 23, 2026 07:51
6e0b299 to
a95f5fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetN/SetI/SetPV/SetPMT/SetFV are already variadic (PR #16). This cleans up the callers:
c.e.SetN()instead ofc.e.SetN(c.e.X)