-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compromised GH action #1714
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe GitHub Actions workflow has been updated to replace the previous Changes
Sequence Diagram(s)sequenceDiagram
participant C as Commit Trigger
participant W as GitHub Workflow
participant S as Shell Script
participant G as Git Diff
C->>W: Push new commit
W->>S: Invoke custom shell script
S->>G: Run git diff between commits
G-->>S: Return diff results
S->>W: Set and output ANY_CHANGED (true/false)
W->>Next: Execute conditional workflow steps based on ANY_CHANGED
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/examples.yml (1)
24-36
: Replace the compromised action with a custom diff check
The new shell script correctly usesgit diff
to detect changes across the specified paths and sets theANY_CHANGED
flag accordingly. To improve robustness, consider adding error handling (for example, aset -e
at the start of the script) to ensure that any errors in the diff command cause an immediate failure rather than proceeding with possibly invalid output.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/examples.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: dummy-app-integration-tests (oldest)
- GitHub Check: dummy-app-integration-tests (newest)
- GitHub Check: rspec-package-tests (oldest)
- GitHub Check: rspec-package-tests (newest)
- GitHub Check: build
Pull Request checklist
[ ] Add/update test to cover these changes[ ] Update documentation[ ] Update CHANGELOG fileThis change is
Summary by CodeRabbit