Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-on-rails import to /client as needed #1703

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexeyr-ci
Copy link
Collaborator

@alexeyr-ci alexeyr-ci commented Mar 2, 2025

Summary

Update documentation and examples after #1697.

Pull Request checklist

- [ ] Add/update test to cover these changes

  • Update documentation
    - [ ] Update CHANGELOG file

This change is Reviewable

Summary by CodeRabbit

  • Documentation

    • Revised API documentation and guides to reflect updated client-specific import paths and improved code examples.
    • Enhanced instructions and examples for differentiating client and server integrations.
  • Chores

    • Updated internal scripts to support flexible version matching and maintain overall consistency.

Copy link
Contributor

coderabbitai bot commented Mar 2, 2025

Walkthrough

This pull request updates various documentation and example files to reflect a more explicit usage of client-specific import paths for ReactOnRails. The changes include updates to import references in documentation, guides, code examples, and dummy application views. Additionally, a method in the DevTestsGenerator was modified for managing local dependencies, test commands were updated in CONTRIBUTING.md, and the conversion script was adjusted to use regular expressions for gem version matching.

Changes

File(s) Change Summary
docs/api/javascript-api.md
docs/guides/how-to-use-different-files-for-client-and-server-rendering.md
docs/javascript/code-splitting.md
Updated documentation to replace generic references (e.g., ReactOnRails.ts and 'react-on-rails') with explicit client and server-specific paths (e.g., ReactOnRails.client.ts and 'react-on-rails/client'), along with minor formatting adjustments.
spec/dummy/app/views/pages/*.erb
spec/dummy/client/app/startup/ReduxSharedStoreApp.client.jsx
spec/dummy/client/app/packs/client-bundle.js
Revised import statements for ReactOnRails to use the client-specific path ('react-on-rails/client') across multiple dummy application files and examples.
lib/generators/react_on_rails/dev_tests_generator.rb
lib/generators/.../registration.js.tt
Updated the method for modifying package.json for local dependency linking, and changed the registration template to import from 'react-on-rails/client'.
CONTRIBUTING.md Updated test command references (e.g., replacing rake run_rspec:example_basic with rake run_rspec:shakapacker_examples_basic) and corrected a typographical error.
script/convert Modified regex patterns in file content substitution to allow for more flexible matching of "shakapacker" gem versions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DevTestsGenerator
    participant PackageJson

    User->>DevTestsGenerator: Run make_react_on_rails_dependency_local
    DevTestsGenerator->>PackageJson: Read package.json content
    PackageJson-->>DevTestsGenerator: Return file content
    DevTestsGenerator->>PackageJson: Update react-on-rails dependency (local via yalc)
    DevTestsGenerator->>PackageJson: Write updated content back to package.json
Loading

Possibly related PRs

  • Update CHANGELOG for 14.2.0 #1704: The changes in the main PR, which update documentation references to the ReactOnRails.client.ts, are related to the retrieved PR that introduces the export option 'react-on-rails/client', as both involve modifications to the usage and documentation of the client-specific version of the ReactOnRails library.
  • Reduce bundle size #1697: The changes in the main PR, which update documentation references for the ReactOnRails module, are related to the retrieved PR that modifies the import paths for the same module, specifically to ReactOnRails.client, indicating a direct connection in how the module is referenced across documentation and code.
  • fix: address a number of typos and grammar issues #1631: The changes in the main PR, which update documentation references for the ReactOnRails module, are related to the changes in the retrieved PR that also involve modifications to documentation regarding the ReactOnRails library, specifically in the docs/javascript/code-splitting.md file. Both PRs focus on clarifying the usage and import paths of the ReactOnRails module.

Suggested reviewers

  • Judahmeek
  • Romex91

Poem

I’m a rabbit with a code trove so bright,
Hopping through docs with imports just right.
Client paths now gleam under the moon’s soft light,
Local dependencies fixed in a cheerful flight.
With a twitch of my nose, I say "Thump-thump, hooray!" 🐰
Celebrate the changes in a boppy, code-filled ballet.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88e3390 and 72040b5.

📒 Files selected for processing (13)
  • CONTRIBUTING.md (1 hunks)
  • docs/api/javascript-api.md (1 hunks)
  • docs/guides/how-to-use-different-files-for-client-and-server-rendering.md (2 hunks)
  • docs/javascript/code-splitting.md (3 hunks)
  • lib/generators/react_on_rails/dev_tests_generator.rb (1 hunks)
  • lib/generators/react_on_rails/templates/base/base/app/javascript/packs/registration.js.tt (1 hunks)
  • script/convert (1 hunks)
  • spec/dummy/app/views/pages/client_side_hello_world.html.erb (1 hunks)
  • spec/dummy/app/views/pages/server_side_hello_world.html.erb (1 hunks)
  • spec/dummy/app/views/pages/server_side_redux_app.html.erb (1 hunks)
  • spec/dummy/app/views/pages/server_side_redux_app_cached.html.erb (1 hunks)
  • spec/dummy/app/views/pages/xhr_refresh.html.erb (1 hunks)
  • spec/dummy/client/app/startup/ReduxSharedStoreApp.client.jsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (13)
  • spec/dummy/client/app/startup/ReduxSharedStoreApp.client.jsx
  • lib/generators/react_on_rails/templates/base/base/app/javascript/packs/registration.js.tt
  • docs/api/javascript-api.md
  • spec/dummy/app/views/pages/server_side_hello_world.html.erb
  • spec/dummy/app/views/pages/xhr_refresh.html.erb
  • spec/dummy/app/views/pages/server_side_redux_app_cached.html.erb
  • lib/generators/react_on_rails/dev_tests_generator.rb
  • CONTRIBUTING.md
  • spec/dummy/app/views/pages/client_side_hello_world.html.erb
  • script/convert
  • spec/dummy/app/views/pages/server_side_redux_app.html.erb
  • docs/guides/how-to-use-different-files-for-client-and-server-rendering.md
  • docs/javascript/code-splitting.md
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: rspec-package-tests (oldest)
  • GitHub Check: build
  • GitHub Check: rspec-package-tests (newest)
  • GitHub Check: build-dummy-app-webpack-test-bundles (oldest)
  • GitHub Check: examples (oldest)
  • GitHub Check: examples (newest)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alexeyr-ci alexeyr-ci force-pushed the alexeyr/update-client-imports branch 2 times, most recently from 7210fe2 to 745c1f3 Compare March 3, 2025 09:00
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
lib/generators/react_on_rails/base_generator.rb (1)

79-93: 💡 Verification agent

🧩 Analysis chain

Verify consistency with import path changes.

This generator change supports the overall PR objective of updating react-on-rails imports, but I should verify whether the generated code templates also reflect the updated import paths (from 'react-on-rails' to 'react-on-rails/client') mentioned in the PR summary.


🏁 Script executed:

#!/bin/bash
# Check if the templates used by this generator have been updated to use the new import path

# Look for import statements in JavaScript templates
echo "Checking for import statements in JavaScript templates:"
rg "from\s+['\"]react-on-rails['\"]" lib/generators/react_on_rails/templates/ -g "*.js*" -g "*.ts*"

# Look for any react-on-rails imports in other files
echo "Checking other template files for react-on-rails imports:"
rg "react-on-rails" lib/generators/react_on_rails/templates/ -g "!*.rb"

Length of output: 825


Update Generator Template Import Paths for Consistency

We verified that while registration.js.tt correctly uses the updated import path (react-on-rails/client), the file lib/generators/react_on_rails/templates/base/base/app/javascript/packs/server-bundle.js still imports from react-on-rails. Please update the import in server-bundle.js to use react-on-rails/client to ensure all generated templates align with the updated PR objective.

🧹 Nitpick comments (2)
script/convert (2)

16-16: Improved regex pattern for matching shakapacker gem version

The change from a fixed string to a regular expression pattern (/gem "shakapacker", "[^"]*"/) makes the script more robust by allowing it to match any version of the shakapacker gem before replacing it with version 6.6.0.

Consider adding a comment explaining why this specific version (6.6.0) is being used to help future maintainers understand the version selection reasoning.


16-22: Ensure consistent version management across the codebase

While the script now handles version patterns more flexibly, it's worth noting that hardcoded version numbers (6.6.0) appear in multiple places. This could make future version updates more error-prone.

Consider defining the version number as a variable at the top of the script to ensure consistency:

#!/usr/bin/env ruby
# frozen_string_literal: true

+SHAKAPACKER_VERSION = "6.6.0"
+
def gsub_file_content(path, old_content, new_content)
  path = File.expand_path(path, __dir__)
  content = File.binread(path)
  content.gsub!(old_content, new_content)
  File.binwrite(path, content)
end

old_config = File.expand_path("../spec/dummy/config/shakapacker.yml", __dir__)
new_config = File.expand_path("../spec/dummy/config/webpacker.yml", __dir__)

File.rename(old_config, new_config)

-gsub_file_content("../Gemfile.development_dependencies", /gem "shakapacker", "[^"]*"/, 'gem "shakapacker", "6.6.0"')
+gsub_file_content("../Gemfile.development_dependencies", /gem "shakapacker", "[^"]*"/, "gem \"shakapacker\", \"#{SHAKAPACKER_VERSION}\"")

# The below packages don't work on the oldest supported Node version and aren't needed there anyway
gsub_file_content("../package.json", /"knip": "[^"]*",/, "")
gsub_file_content("../package.json", %r{"@arethetypeswrong/cli": "[^"]*",}, "")

-gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "6.6.0",')
+gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, "\"shakapacker\": \"#{SHAKAPACKER_VERSION}\",")
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7210fe2 and 745c1f3.

📒 Files selected for processing (14)
  • CONTRIBUTING.md (1 hunks)
  • docs/api/javascript-api.md (1 hunks)
  • docs/guides/how-to-use-different-files-for-client-and-server-rendering.md (2 hunks)
  • docs/javascript/code-splitting.md (3 hunks)
  • lib/generators/react_on_rails/base_generator.rb (1 hunks)
  • lib/generators/react_on_rails/dev_tests_generator.rb (1 hunks)
  • lib/generators/react_on_rails/templates/base/base/app/javascript/packs/registration.js.tt (1 hunks)
  • script/convert (1 hunks)
  • spec/dummy/app/views/pages/client_side_hello_world.html.erb (1 hunks)
  • spec/dummy/app/views/pages/server_side_hello_world.html.erb (1 hunks)
  • spec/dummy/app/views/pages/server_side_redux_app.html.erb (1 hunks)
  • spec/dummy/app/views/pages/server_side_redux_app_cached.html.erb (1 hunks)
  • spec/dummy/app/views/pages/xhr_refresh.html.erb (1 hunks)
  • spec/dummy/client/app/startup/ReduxSharedStoreApp.client.jsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (11)
  • spec/dummy/client/app/startup/ReduxSharedStoreApp.client.jsx
  • docs/guides/how-to-use-different-files-for-client-and-server-rendering.md
  • lib/generators/react_on_rails/templates/base/base/app/javascript/packs/registration.js.tt
  • lib/generators/react_on_rails/dev_tests_generator.rb
  • spec/dummy/app/views/pages/server_side_redux_app_cached.html.erb
  • spec/dummy/app/views/pages/server_side_redux_app.html.erb
  • spec/dummy/app/views/pages/server_side_hello_world.html.erb
  • spec/dummy/app/views/pages/client_side_hello_world.html.erb
  • spec/dummy/app/views/pages/xhr_refresh.html.erb
  • docs/javascript/code-splitting.md
  • docs/api/javascript-api.md
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: dummy-app-integration-tests (newest)
  • GitHub Check: dummy-app-integration-tests (oldest)
  • GitHub Check: examples (newest)
  • GitHub Check: rspec-package-tests (newest)
  • GitHub Check: examples (oldest)
  • GitHub Check: rspec-package-tests (oldest)
🔇 Additional comments (4)
CONTRIBUTING.md (1)

219-219: Update Reflects New Testing Workflow

The updated command instructions now correctly reference the new test tasks (rake run_rspec:shakapacker_examples_basic and rake run_rspec:shakapacker_examples). The note explaining that these commands will generate a huge number of files reinforces the importance of excluding the /gen-examples directory from your IDE, which is very useful to prevent potential performance issues. Overall, the changes are clear, consistent with the PR objectives, and enhance the documentation effectively.

lib/generators/react_on_rails/base_generator.rb (2)

79-81: Good addition of a utility method for local development.

This method provides a convenient hook that could be overridden in subclasses or for local development purposes to use a local version of the react-on-rails package instead of the published one.


85-87: Clean implementation of local development support.

The conditional logic integrates well with the existing code. This change allows developers to use a local version of the react-on-rails package (from .yalc directory) when developing or testing changes to the package itself. This is particularly useful for maintainers who need to test compatibility with the generator before publishing changes.

script/convert (1)

1-28:

❓ Verification inconclusive

Relationship with PR objectives needs verification

The PR is titled "Update react-on-rails import to /client as needed", but this script doesn't directly modify import paths. It focuses on shakapacker version management and webpack configuration changes.

Let's check if this script is part of a larger update process that might indirectly support the import path changes:


🏁 Script executed:

#!/bin/bash
# Description: Check if this script is part of a process that updates import paths

# Look for other files mentioning import path changes
echo "Files containing both 'react-on-rails' and '/client' references:"
rg -l "react-on-rails/client" | head -n 10

# Check if this script is called from other scripts that might be doing the import updates
echo -e "\nChecking if this script is referenced in other files:"
rg -l "script/convert" --type-not ruby | head -n 5

Length of output: 931


Clarification Required: Confirm Conversion Script’s Role in PR Objectives

  • The script/convert file currently focuses on renaming configuration files, updating shakapacker-related versions in the Gemfile and package.json files, and adjusting webpack configuration calls.
  • No modifications targeting react-on-rails import paths (i.e. updating them to /client) are evident here.
  • A repository search shows that while several files include /client references for react-on-rails, this script is only referenced in documentation (CONTRIBUTING.md) and does not directly perform any import updates.
  • Please clarify whether:
    • This script is meant to work in tandem with other changes that handle react-on-rails import updates, or
    • The PR title/description needs updating to reflect the actual scope of changes.


# The below packages don't work on the oldest supported Node version and aren't needed there anyway
gsub_file_content("../package.json", /"knip": "[^"]*",/, "")
gsub_file_content("../package.json", %r{"@arethetypeswrong/cli": "[^"]*",}, "")

gsub_file_content("../spec/dummy/package.json", '"shakapacker": "8.0.0",', '"shakapacker": "6.6.0",')
gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "6.6.0",')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Enhanced flexibility for package.json version matching

Similar to the Gemfile change, this improves the script by using a regex pattern to match any version of shakapacker in the package.json file before replacing it with a specific version.

Let's verify that both the gem and npm package versions are aligned at 6.6.0:


🏁 Script executed:

#!/bin/bash
# Description: Verify that both the gem version in Gemfile.development_dependencies
# and npm package version in spec/dummy/package.json are set to 6.6.0

echo "Checking Gemfile.development_dependencies for shakapacker version:"
cat Gemfile.development_dependencies | grep -E 'gem "shakapacker"'

echo -e "\nChecking spec/dummy/package.json for shakapacker version:"
cat spec/dummy/package.json | grep -E '"shakapacker":'

Length of output: 454


Version mismatch detected – update the hardcoded version

The regex pattern in the conversion script is sound for flexible matching, but the replacement value is outdated. The command in script/convert (line 22) currently sets shakapacker to "6.6.0", whereas both the Gemfile and spec/dummy/package.json verify that shakapacker is now at "8.0.0". Please update the replacement value accordingly.

  • File: script/convert (line 22)
  • Diff Suggestion:
    - gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "6.6.0",')
    + gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "8.0.0",')
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "6.6.0",')
gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "8.0.0",')

@alexeyr-ci alexeyr-ci force-pushed the alexeyr/update-client-imports branch from 745c1f3 to 457da34 Compare March 3, 2025 09:17
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
lib/generators/react_on_rails/dev_tests_generator.rb (3)

60-65: Good addition of a dependency management method, but line length exceeds limit.

The new method effectively complements the existing add_yarn_relative_install_script_in_package_json method by replacing the version specification in package.json to use a local yalc-linked version. This is a useful addition for local development workflows.

To fix the line length issue reported by Rubocop (134/120 characters), consider breaking up the regex line:

- new_client_package_json_contents = contents.gsub(/"react-on-rails": "[^"]*"/, '"react-on-rails": "link:.yalc/react-on-rails"')
+ pattern = /"react-on-rails": "[^"]*"/
+ replacement = '"react-on-rails": "link:.yalc/react-on-rails"'
+ new_client_package_json_contents = contents.gsub(pattern, replacement)
🧰 Tools
🪛 RuboCop (1.73)

[convention] 63-63: Line is too long. [134/120]

(Layout/LineLength)

🪛 GitHub Actions: Lint JS and Ruby

[warning] 63-63: Rubocop: Line is too long. [134/120]


60-65: Consider adding error handling for file operations.

The method currently doesn't handle cases where the package.json file might not exist or where the react-on-rails dependency might be missing or formatted differently.

 def make_react_on_rails_dependency_local
   package_json = File.join(destination_root, "package.json")
+  return unless File.exist?(package_json)
   contents = File.read(package_json)
-  new_client_package_json_contents = contents.gsub(/"react-on-rails": "[^"]*"/, '"react-on-rails": "link:.yalc/react-on-rails"')
+  pattern = /"react-on-rails": "[^"]*"/
+  replacement = '"react-on-rails": "link:.yalc/react-on-rails"'
+  new_client_package_json_contents = contents.gsub(pattern, replacement)
+  # Verify the replacement happened
+  if contents == new_client_package_json_contents
+    puts "Warning: Could not find 'react-on-rails' dependency in package.json"
+  end
   File.open(package_json, "w+") { |f| f.puts new_client_package_json_contents }
 end
🧰 Tools
🪛 RuboCop (1.73)

[convention] 63-63: Line is too long. [134/120]

(Layout/LineLength)

🪛 GitHub Actions: Lint JS and Ruby

[warning] 63-63: Rubocop: Line is too long. [134/120]


60-65: Add documentation comment explaining the method's purpose.

A documentation comment would help developers understand the method's purpose and how it relates to the overall workflow.

+# Modifies the package.json to use a local version of react-on-rails via yalc
+# This works in conjunction with the postinstall script added by add_yarn_relative_install_script_in_package_json
 def make_react_on_rails_dependency_local
   package_json = File.join(destination_root, "package.json")
   contents = File.read(package_json)
   new_client_package_json_contents = contents.gsub(/"react-on-rails": "[^"]*"/, '"react-on-rails": "link:.yalc/react-on-rails"')
   File.open(package_json, "w+") { |f| f.puts new_client_package_json_contents }
 end
🧰 Tools
🪛 RuboCop (1.73)

[convention] 63-63: Line is too long. [134/120]

(Layout/LineLength)

🪛 GitHub Actions: Lint JS and Ruby

[warning] 63-63: Rubocop: Line is too long. [134/120]

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 745c1f3 and 457da34.

📒 Files selected for processing (4)
  • CONTRIBUTING.md (1 hunks)
  • lib/generators/react_on_rails/dev_tests_generator.rb (1 hunks)
  • lib/generators/react_on_rails/templates/base/base/app/javascript/packs/registration.js.tt (1 hunks)
  • script/convert (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • script/convert
  • CONTRIBUTING.md
  • lib/generators/react_on_rails/templates/base/base/app/javascript/packs/registration.js.tt
🧰 Additional context used
🪛 RuboCop (1.73)
lib/generators/react_on_rails/dev_tests_generator.rb

[convention] 63-63: Line is too long. [134/120]

(Layout/LineLength)

🪛 GitHub Actions: Lint JS and Ruby
lib/generators/react_on_rails/dev_tests_generator.rb

[warning] 63-63: Rubocop: Line is too long. [134/120]

⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: dummy-app-integration-tests (newest)
  • GitHub Check: rspec-package-tests (newest)
  • GitHub Check: examples (newest)
  • GitHub Check: rspec-package-tests (oldest)
  • GitHub Check: examples (oldest)

@alexeyr-ci alexeyr-ci force-pushed the alexeyr/update-client-imports branch from 457da34 to 88e3390 Compare March 3, 2025 09:32
@alexeyr-ci alexeyr-ci force-pushed the alexeyr/update-client-imports branch from 88e3390 to 72040b5 Compare March 7, 2025 10:03
@alexeyr-ci alexeyr-ci marked this pull request as draft March 10, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants