Fix DX on VK #40
Merged
Fix DX on VK #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could probably be a little neater, as at the moment it conflates dxvk with being not on windows, but I think that if anyone wants to use dxvk on Windows they can cope with improving this
expipiplus1
added a commit
to expipiplus1/slang
that referenced
this pull request
Sep 17, 2024
Requires this PR shader-slang/slang-rhi#40
|
so does this assume that dxvk is installed system wide? otherwise, where would we get the D3D headers from? |
csyonghe
added a commit
to shader-slang/slang
that referenced
this pull request
Sep 19, 2024
Requires this PR shader-slang/slang-rhi#40 Co-authored-by: Yong He <[email protected]>
|
It does, I found it hard to imagine any serious Linux user not having the dx headers installed in 2024 ahahah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could probably be a little neater, as at the moment it conflates dxvk with being not on windows, but I think that if anyone wants to use dxvk on Windows they can cope with improving this