Remove specialization logic for interfaces in structured buffers. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
skallweitNV
reviewed
Nov 28, 2024
|
It applies to all backends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete some unnecessary specialization logic around handling of
StructuredBuffer<IFoo>, since we no longer treat a shader parameter ofStructuredBuffer<IFoo>type as a specializable parameter. Such parameters will always treatIFooas a dynamically dispatched element instead of something specializable, because it is not very meaningful to specialize StructuredBuffer to StructuredBuffer. In practice the StructuredBuffer usually represent a heterogeneous array.