Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove several dependencies #8

Merged
merged 7 commits into from
May 14, 2024

Conversation

qudix
Copy link

@qudix qudix commented May 13, 2024

  • remove robin-hood-hashing
    • performance difference is negligible compared to std::unordered_map and not worth the extra dependency
  • remove boost's stl_interfaces::iterator_interface
    • additionally, only BSTArray uses stl_interfaces::sequence_container_interface but it's much larger than the others and I'm unsure how to go about removing it properly; if someone else can do it then we can remove boost entirely.
  • remove fmt
    • should be backwards compatible with projects still using fmt
  • remove frozen
    • the need for a highly performant constexpr map class isn't necessary here given it's not on a hot path
  • remove nowide
  • silence external warning caused by xbyak
  • add runtime version 1.10.984.0

one thing to consider is whether we should remove the F4SEStub projects given ryan never finished them and are unused anywhere. they are a bit of a maintenance burden trying to keep them building when making changes like this.

@shad0wshayd3 shad0wshayd3 merged commit 6f7f329 into shad0wshayd3-FO4:master May 14, 2024
1 check failed
shad0wshayd3 pushed a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants