Update to 1.20.5-1.21 #912
Conversation
- Update maven plugins dependencies - Rework a bit packet accessors to support both legacy craft bukkit package versions & modern paper mapping
|
Nice! |
|
Thanks so much man. Honestly you're a life saver. |
|
upload the plugin to, 1.20.6, PLS |
|
Same file |
|
What?
Obtener Outlook para iOS<https://aka.ms/o0ukef>
…________________________________
De: Cory Gillenkirk ***@***.***>
Enviado: Saturday, July 13, 2024 9:14:31 PM
Para: sgtcaze/NametagEdit ***@***.***>
Cc: Shadow80456 ***@***.***>; Comment ***@***.***>
Asunto: Re: [sgtcaze/NametagEdit] Update to 1.20.5-1.21 (PR #912)
Same file
—
Reply to this email directly, view it on GitHub<#912 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BJRSNK5THOUR5C67CBVN3JTZMHUJPAVCNFSM6AAAAABKPYK4LSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGE3TSNZSGQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Hey sorry for the late reply. But when its "active":
^^' |
As far as I know this plugin may not be directly supported. I don't think it is related to the 1.21 update, please tell me if it is not the case. Note that NameTagEdit has its own handling and probably overrides all other changes made from other plugins such as Ultrapermissions (that are not aware of NTE). |
|
Thats strange cause UltraPermission names just your Plugin as functional. If i remove it, UltraPermission says that for this function "NameTagEdit" is needed. |
|
Right, sorry for the confusion. I can't really see what would cause that on our side. Can you reproduce it on older versions (e.g. 1.20.4)? |
|
Hello! Thanks for providing this build. It worked great on 1.21! |
|
@Erlpil Thanks for the feedback. The provided plugin has been updated, you can try it out! |
|
@Aurelien30000 hex colours don't seem to work for usernames, it uses the last digit of the hex code as the username colour 
|
|
@mxz7 That's a weird issue but you are right, it seems that combined color codes/non standard colors (as last) no longer work. I have also noticed that simple formatting such as I will investigate further & try to fix the issue. |
|
Apparently, from the first checks I have done, the method used by NTE (team) is no longer suitable for "coloring" the player name as before (bold, previous colors from the prefix, etc.). Only basic colors may be supported. The issue could be fixed by using an alternative method or another plugin. Anyways, I will make further investigations and maybe try to make a Mojang report. |
|
Yeah I moved to TAB and seems to work better for my needs, a bit more complicated but way more features |
|
We are back to the grind with the 1.21.3 stable release with paper. Tried to run the provided build in the original post on papers build 59 for 1.21.3 and got this error: https://pastebin.com/raw/XV3diQgh Are you planning on keeping this project alive @Aurelien30000 , or is it time for us to start to look elsewhere? |
@Erlpil Sure, sorry for the delay, NameTagEdit has been updated to support 1.21.2+. You can download artifacts from here: https://github.com/Aurelien30000/NametagEdit/actions/runs/12076523603 |
|
Thanks for the patch! Worked like a charm on paper 1.21.3 build 76! We really appreciate you keeping this plugin alive! |
Hi, thanks for reaching me out. I able currently unable to reproduce your issue. Can you provide more details about your server setup, plugins and NTE configuration? Thanks ! |
|
@Nandi0813 Please could you provide the requested additional information? Thanks |
|
Hi @Aurelien30000 The plugin is breaking in 1.21.4, can you fix it? [23:22:03 INFO]: [NametagEdit] Enabling NametagEdit v4.5.24
[23:22:03 INFO]: [NametagEdit] Disabling NametagEdit v4.5.24
[23:22:03 ERROR]: Error occurred while disabling NametagEdit v4.5.24
java.lang.NullPointerException: Cannot invoke "com.nametagedit.plugin.NametagManager.reset()" because "this.manager" is null
at NametagEdit.jar/com.nametagedit.plugin.NametagEdit.onDisable(NametagEdit.java:86) ~[NametagEdit.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:290) ~[purpur-api-1.21.4-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugin(PaperPluginInstanceManager.java:237) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.disablePlugin(PaperPluginManagerImpl.java:114) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:550) ~[purpur-api-1.21.4-R0.1-SNAPSHOT.jar:?]
at NametagEdit.jar/com.nametagedit.plugin.NametagEdit.testCompat(NametagEdit.java:106) ~[NametagEdit.jar:?]
at NametagEdit.jar/com.nametagedit.plugin.NametagEdit.onEnable(NametagEdit.java:39) ~[NametagEdit.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:284) ~[purpur-api-1.21.4-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[purpur-api-1.21.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:670) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:619) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:746) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:491) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:365) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1178) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:313) ~[purpur-1.21.4.jar:1.21.4-2387-4f48185]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
[23:22:03 ERROR]: [NametagEdit]
------------------------------------------------------
[WARNING] NametagEdit v4.5.24 Failed to load! [WARNING]
------------------------------------------------------
This might be an issue with reflection. REPORT this:
> Cannot invoke "java.lang.reflect.Field.set(Object, Object)" because "com.nametagedit.plugin.packets.PacketAccessor.PARAMS" is null
The plugin will now self destruct.
------------------------------------------------------ |
|
@Brasil150 Try the latest build at https://github.com/Aurelien30000/NametagEdit/actions/workflows/maven.yml - it looks like you might be running NametagEdit 1.21.2/1.21.3 |
|
Nametagedit breaks login on BungeeCord build 1899 and later. Hello again @Aurelien30000 ! We are running tour latest build for NametagEdit downloaded from here: https://github.com/Aurelien30000/NametagEdit/actions/runs/12456443965 During routine maintenance we found that this causes issues when running BungeeCord build 1899 or later. This is the error in the bungee console: pastebin.com/raw/YBCAEXnM I have tried to run BungeeCord without any plugins as well as ripping out all plugins on our hub server. The issue only appeared when NametagEdit was installed. Here is the BungeeCord commit that causes the issue: SpigotMC/BungeeCord@508c2f7 Is there a way you can solve this problem? |
|
Thanks I'm running it on 1.21.4 and it works |
Hi, thanks for the report! This is likely caused by a change in packet internal values that need to be handled in our side. As 1.21.5 is not yet release, I can't guarantee it will be fixed. I'll take a look next week anyways! |
|
Hi @Aurelien30000 any news about Bungeecord changes? |
|
Just a heads up here. Geyser (bedrock proxy solution for java servers) are now forcing people to use an updated version of BungeeCord due to some internal changes. As Bedrock versions are released more frequently than java, there wont be long before server owners will be forced to upgrade their BungeeCord instance, and then remove NameTagEdit due to the error mentioned above. I have tested that the issue with NametagEdit still presist on the current latest BungeeCord build 1918. |
|
Yes @Erlpil Unfortunately I had to remove NameTagEdit to be able to update my Proxy and consequently Geyser and Floodgate as both are requiring the Proxy to be updated. How updating the Proxy causes problems in NametagEdit was the way. Fortunately this problem only happens on servers running higher versions of the game like 1.21. I have a Lobby on 1.12.2 and have had no problems. |
|
@Aurelien30000 como lo descargo para la 1.21.4 porfavor |
You can try it with the following provided
.jar.Please be cautions using it!
1.21.4 supported
https://github.com/Aurelien30000/NametagEdit/actions/runs/12456443965