-
Notifications
You must be signed in to change notification settings - Fork 57
[DFX] Adaptable to multiple model validations for fused moe #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DFX] Adaptable to multiple model validations for fused moe #229
Conversation
Summary of ChangesHello @kaniel-outis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the testing framework for fused Mixture-of-Experts (MoE) models by introducing greater adaptability for different model architectures. The core change involves making the intermediate dimension ( Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adapts the fused MoE tests to support multiple model validations, specifically for different hidden dimensions. This is achieved by making hidden_mid a configurable parameter, calculating hidden_out based on hidden_mid, and generalizing a weight reshaping function. The changes are logical and consistent. I've provided a couple of suggestions to improve documentation accuracy and code clarity.
Adaptable to multiple model validations for fused moe: