feat(oracle): support schema query parameter in connection URL #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for specifying Oracle schema via URL query parameter. When 'schema' is provided, it's automatically set as the current schema for all connections in the pool.
|
Thanks @kongscn for the PR! The code looks good to me. Can you also add this to the documentation? I can merge it after that. |
|
Thanks for review! I just added a short section in the doc and assuming this will be available for version |
|
Thanks @kongscn for the quick update, I have merged the PR. This feature will be included from version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying Oracle schema via URL query parameter like
?schema=abc. When 'schema' is provided, it's automatically set as the current schema for all connections in the pool.